fix: glue health check should probe configured catalog_id - #142
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Glue plugin’s cluster health check so it probes the configured Glue Data Catalog (via CatalogId) instead of implicitly targeting the caller account’s default catalog, aligning the health check with production configuration and IAM scoping.
Changes:
- Build a
GetDatabasesrequest object and conditionally attachCatalogIdfrom the Glue command configuration. - Use the configured catalog when performing the
/clusters/healthGlue connectivity probe.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
prasadlohakpure
force-pushed
the
fix/glue-health-check-catalog-id
branch
from
August 31, 2026 06:12
c11783d to
f6d93d4
Compare
The glue plugin's HealthCheck was calling glue:GetDatabases without a CatalogId, so it always probed the default catalog for the account the task role runs in, instead of the catalog_id configured for the glue command. This meant the health check exercised a different Glue catalog than the one Execute() actually uses (via GetTable), and was failing with AccessDeniedException because heimdall-task-role has no glue:GetDatabases grant on that unrelated default catalog. Pass the command's configured CatalogId through to GetDatabases so the health check validates the catalog access the command actually depends on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
prasadlohakpure
force-pushed
the
fix/glue-health-check-catalog-id
branch
from
August 31, 2026 06:14
f6d93d4 to
d186e8a
Compare
Yash Shrivastava (alephys26)
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/clusters/healthglue health check callsglue:GetDatabaseswith noCatalogId, so it always probes the default catalog for the account the task role runs in — not thecatalog_idactually configured for the glue command (842676014003in prod config). This is failing:The
glueplugin does not have flexibility to define catalog arn on which it wants to perform health check. Bases on the role/identity assigned it will try health check default catalog within same AWS account.Fix
Pass the command's configured
CatalogIdthrough toGetDatabases, so the health check validates access to the catalog the command actually depends on, instead of an unrelated default catalog.Testing
./build.sh --go— all commands and plugins (includingglue) build cleanly.🤖 Generated with Claude Code