Add a Done gate to the v4 CI - #2989
Merged
Merged
Conversation
One job after the matrix, so branch protection requires "Done" instead of listing every leg. Same check name as main and rel/5.x.x, which is the point, one branch policy covers all three. Renames the workflow to "CI (v4)". test-report.yml on main runs after every workflow named "CI" and renders its results, and Pester 4 can only write NUnit 2.5 XML, which dorny/test-reporter cannot read. upload-artifact v7 while here, v4 still ran on Node 20. 🤖
nohwnd
added a commit
that referenced
this pull request
Aug 22, 2026
Renaming the workflow in #2989 was not enough. A workflow is identified by its file path, and the name comes from the copy on the default branch, so this file was still labelled "CI" because main has a ci.yml. test-report.yml on main runs after every workflow named "CI", and it failed on every v4 run, Pester 4 writes NUnit 2.5 XML that dorny/test-reporter cannot read. ci.yml becomes ci-v4.yml, which makes it a separate workflow with its own name. The gate job is still "Done". 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Donejob after the test matrix, so branch protection on this branch requires one check instead of every leg. Same check name as main (#2905) and rel/5.x.x (#2988), which is the point, one branch policy then covers all three.The workflow is renamed to
CI (v4).test-report.ymlon main runs after every workflow namedCIand renders the results, and Pester 4 can only write NUnit 2.5 XML, which dorny/test-reporter cannot read. The job names are untouched, so the check is stillDonehere.upload-artifactgoes to v7 while here, v4 still ran it on Node 20.Note this branch has no
code-analysis.yml, soPSScriptAnalyzercan never report here and has to come off this branch's rule.🤖