appendices: note the E_STRICT deprecation (8.4.0), mark T_PROPERTY_C available as of 8.4.0 - #5799
Open
lacatoire wants to merge 1 commit into
Open
appendices: note the E_STRICT deprecation (8.4.0), mark T_PROPERTY_C available as of 8.4.0#5799lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
…available as of 8.4.0 reserved.constants.core.xml - split E_STRICT out of the shared listitem so the note applies to it alone, and state that the constant is unused and deprecated, matching the wording of reference/errorfunc/constants.xml - the new varlistentry carries no xml:id on purpose: constant.e-strict is already used by reference/errorfunc/constants.xml tokens.xml - T_PROPERTY_C is the last of the four tokens added in 8.4.0 still missing its version annotation, the other three (T_PRIVATE_SET, T_PROTECTED_SET, T_PUBLIC_SET) already carry it Sources - E_STRICT constant deprecated, error level removed: https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant - T_PROPERTY_C / __PROPERTY__: https://wiki.php.net/rfc/property-hooks
lacatoire
force-pushed
the
sync-src/reserved-constants-fixes
branch
from
August 26, 2026 09:29
3ba19a1 to
4a8c75b
Compare
lacatoire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two 8.4.0 annotations missing from the appendices.
appendices/reserved.constants.core.xmlE_STRICTis split out of the shared listitem so the note applies to it alone, and states that the constant is unused and deprecated, matching the wording already used byreference/errorfunc/constants.xmlvarlistentrycarries noxml:idon purpose:constant.e-strictis already taken byreference/errorfunc/constants.xml, a duplicate would break the buildappendices/tokens.xmlT_PROPERTY_Cis the last of the four tokens added in 8.4.0 still missing its version annotation; the other three (T_PRIVATE_SET,T_PROTECTED_SET,T_PUBLIC_SET) already carry itSources
E_STRICTconstant deprecated, error level removedCONST_DEPRECATEDinZend/zend_constants.stub.phpT_PROPERTY_C/__PROPERTY__Zend/zend_language_scanner.l