ext/session: document the 8.4.0 INI deprecations, drop the removed hash_function recommendation - #5800
Open
lacatoire wants to merge 1 commit into
Open
ext/session: document the 8.4.0 INI deprecations, drop the removed hash_function recommendation#5800lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
lacatoire
force-pushed
the
sync-src/session-fixes
branch
2 times, most recently
from
August 26, 2026 09:27
67b8f63 to
8dc4427
Compare
lacatoire
changed the title
…unction recommendation The 8.4.0 session INI deprecations are conditional: PHP only emits E_DEPRECATED when a setting is moved away from its default value, so the wording says "changing" / "enabling" / "setting a non-empty value" rather than describing the settings themselves as deprecated. reference/session/ini.xml - session.sid_length and session.sid_bits_per_character: keep the availability note, add the deprecation as a <warning>, matching the other 8.4.0 deprecations in this file - align the two summary table rows with the same wording reference/session/security.xml - add the deprecation warnings for session.use_trans_sid, session.trans_sid_tags, session.trans_sid_hosts and session.referer_check - drop the session.hash_function recommendation, the setting was removed in PHP 7.1.0 - fix a sentence fragment in the session.referer_check item Sources - Changing session.sid_length / session.sid_bits_per_character: https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character ext/session/session.c (val != 32, val != 4 guards) - use_trans_sid, trans_sid_tags, trans_sid_hosts, referer_check: https://wiki.php.net/rfc/deprecate-get-post-sessions - session.hash_function removed in PHP 7.1.0
lacatoire
force-pushed
the
sync-src/session-fixes
branch
from
August 26, 2026 09:31
8dc4427 to
db59ac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 8.4.0 session INI deprecations are conditional: PHP only emits
E_DEPRECATEDwhen a setting is moved away from its default value. The wording therefore says changing / enabling / setting a non-empty value rather than describing the settings themselves as deprecated, which is also howreference/session/ini.xmlalready words the deprecations added earlier.reference/session/ini.xmlsession.sid_lengthandsession.sid_bits_per_character: keep the availability note and add the deprecation as a<warning>, matching the five other 8.4.0 deprecations in this filereference/session/security.xmlsession.use_trans_sid,session.trans_sid_tags,session.trans_sid_hostsandsession.referer_checksession.hash_functionrecommendation: the setting was removed in PHP 7.1.0, and the entry still recommended feeding it entropy throughsession.entropy_length, removed at the same timesession.referer_checkitemSources
session.sid_length/session.sid_bits_per_characterval != 32/val != 4inext/session/session.csession.use_trans_sid, settingsession.trans_sid_tags/session.trans_sid_hosts/session.referer_checksession.hash_functionremovedini.xml