Zend: Store user error handler as an FCC - #23002
Draft
Girgias wants to merge 6 commits into
Draft
Conversation
To prevent needing to include all of zend_API.h just to have access to those structs
Girgias
force-pushed
the
2026-08-set_error_handler_fcc_convertion
branch
from
August 3, 2026 18:59
90d96fa to
da1d765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently marking as draft as I'm not sure I have a good solution to handle the static method case as they can be represented as
Class::methodor['Class', 'method'], andzend_get_callable_zval_from_fcc()always returns them as an array.I also need more tests to confirm trampolines are handled correctly.
However, storing the error handler as an FCC will prevent redetermining if the zval is callable at every single invocation of said error handler, which I expect happens somewhat regularly.
Moreover, the refactoring here effectively cleans up the fix for the bugsnet bug 63206 done in #5206 by effectively tracking the error handler position on the stack so that we don't need to make a copy of the error handler.