Skip to content

[diffs] CodeView: Ctrl+F - #833

Draft
amadeus wants to merge 6 commits into
mainfrom
amadeus/codeview-find
Draft

[diffs] CodeView: Ctrl+F#833
amadeus wants to merge 6 commits into
mainfrom
amadeus/codeview-find

Conversation

@amadeus

@amadeus amadeus commented Jun 18, 2026

Copy link
Copy Markdown
Member

A WIP vibe coded ctrl+f for CodeView.

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pierre-diffshub Ready Ready Preview Sep 2, 2026 12:19am UTC
pierre-docs-diffs Ready Ready Preview Sep 2, 2026 12:19am UTC
pierre-docs-diffshub Ready Ready Preview Sep 2, 2026 12:19am UTC
pierre-docs-trees Ready Ready Preview Sep 2, 2026 12:19am UTC
pierrejs-diff-demo Ready Ready Preview Sep 2, 2026 12:19am UTC

Request Review

@amadeus
amadeus force-pushed the amadeus/codeview-find branch from 751afc2 to c1e7c89 Compare June 23, 2026 23:31
@amadeus
amadeus force-pushed the beta-1.3 branch 2 times, most recently from 09a40a5 to 73ad9ac Compare June 24, 2026 20:52
@amadeus
amadeus force-pushed the amadeus/codeview-find branch from c1e7c89 to 96d7c1c Compare June 24, 2026 21:57
@amadeus
amadeus force-pushed the amadeus/codeview-find branch from 96d7c1c to d83c636 Compare June 30, 2026 19:15
@amadeus
amadeus force-pushed the amadeus/codeview-find branch from d83c636 to 2cc3e4b Compare July 6, 2026 23:04
@amadeus
amadeus force-pushed the amadeus/codeview-find branch from 2cc3e4b to 8dcaa9a Compare July 6, 2026 23:27
@blacksmith-sh

This comment has been minimized.

@amadeus
amadeus force-pushed the amadeus/codeview-find branch from 3f0a104 to a561395 Compare July 16, 2026 23:59
Base automatically changed from beta-1.3 to main July 21, 2026 21:25
@amadeus
amadeus force-pushed the amadeus/codeview-find branch from a561395 to c14bce8 Compare July 27, 2026 21:13
@amadeus
amadeus force-pushed the amadeus/codeview-find branch from c14bce8 to ac717a4 Compare August 5, 2026 00:20

@amadeus amadeus left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrub

I need to more deeply review this... it's probably a fuck ton
Composition tests open the search panel and dispatch IME keyboard events to
its search input. After the panel moved its controls into a shadow root, the
helper still searched the host's light DOM and could not find the input.

Cross the panel shadow boundary in the helper, matching the existing replace
input lookup and the rendered panel structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant