feat(auth): support restricted signing key IDs - #55
Open
rkdud007 wants to merge 2 commits into
Open
Conversation
Let SDK clients sign requests with a restricted key by configuring its registered key ID. Pass keyId and key_id into the JWT protected header as kid in the TypeScript and Python clients, and document and test both paths.
Configure a client with a restricted signing key ID and request a remote URL without a TTL: the SDK mints a one-year token, and the gateway rejects it because restricted keys are limited to one hour. Default the token lifetime to one hour whenever a key ID is set. An explicit defaultTTL, default_ttl, or per-call ttl still takes precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/pierredotco/monorepo/pull/2494
Let SDK clients sign requests with a restricted key by configuring its registered key ID.
Pass keyId and key_id into the JWT protected header as kid in the TypeScript and Python clients, and document and test both paths.