fix(web): keep merge pending until refresh - #6271
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved fd4ffaa This is a well-scoped UI bug fix that prevents a merge button from briefly reappearing due to stale state after a successful action. The changes are self-contained with clear logic and unit tests, affecting only local state management with no backend or security implications. You can customize Macroscope's approvability policy. Learn more. |
What Changed
The Merge button now stays pending until refreshed PR data confirms the merge.
Why
The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.
UI Changes
Before
After
Checklist
Created by GPT-5.6-sol using the Codex harness in T3 Code.
Note
Keep pull request action controls pending until refreshed detail reflects the new state
actionPendingboolean inPullRequestDetailPanelwith apendingActionobject that tracks the pull request key and action, and clears only whenisPullRequestActionReflectedconfirms the new state is visible in the refreshed detail.isPullRequestActionReflectedutility in pullRequestDetail.logic.ts that checks whether the pull request's current state matches the expected post-action state.Macroscope summarized fd4ffaa.