Restore project thread trees and align desktop update versions - #6274
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 66a0df1. Configure here.
| // The original per-project tree remains the default because it preserves | ||
| // project context and lets users expand each project into its threads. The | ||
| // flat sidebar stays available as an explicit opt-out through this setting. | ||
| legacySidebarEnabled: Schema.Boolean.pipe(Schema.withDecodingDefault(Effect.succeed(true))), |
There was a problem hiding this comment.
Sidebar flashes wrong default
Medium Severity
Flipping legacySidebarEnabled to default true leaves useLegacySidebarEnabled gating with settingsHydrated && legacySidebarEnabled, which still forces false until hydration. Most users briefly mount the flat sidebar, then remount the project-tree sidebar once settings load.
Reviewed by Cursor Bugbot for commit 66a0df1. Configure here.
ApprovabilityVerdict: Needs human review This PR changes the default sidebar UI for all users and adds new desktop CLI detection logic. An unresolved review comment identifies a potential sidebar flash bug during hydration that should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |


Summary
Verification
t3 --versionScope
Only the 12 files relevant to this change are included; unrelated dirty working-tree changes were intentionally excluded.
Note
Medium Risk
Changes a user-facing default for all clients and alters SSH remote CLI resolution, which can affect remote session startup and version compatibility. Packaging/update-feed tweaks are lower risk but touch release paths.
Overview
Makes expandable per-project thread trees the default sidebar again (
legacySidebarEnableddefaults totrue), with the flat list kept as an explicit opt-out. Settings copy and tests are updated to match.For packaged macOS apps, SSH remote sessions now prefer a version-matched installed desktop CLI (via
ELECTRON_RUN_AS_NODE) before falling back tonpx/npm, reducing client/server schema skew.Also bumps packages to 0.0.33, defaults local desktop builds to the canonical GitHub update feed, and reuses the prebuilt production
icon.icnswhen staging Mac icons.Reviewed by Cursor Bugbot for commit 66a0df1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Restore project thread trees as default sidebar and add desktop CLI path for remote SSH runner
legacySidebarEnableddefault fromfalsetotrueinClientSettingsSchema, making the expandable per-project thread tree the default sidebar for all clients without an explicit setting.t3install or package-based execution, usingELECTRON_RUN_AS_NODEto invoke the Electron binary as a Node process.resolveDesktopSshCliRunnernow includes adesktopClidescriptor in the runner options, pointing at the installed app's Electron executable and server entry.icon.icnsfromapps/desktop/resources/icon.icnsinstead of generating one from a PNG; local builds without repo env vars default to thepingdotgg/t3codeGitHub repository for update config.Macroscope summarized 66a0df1.