Skip to content

Restore project thread trees and align desktop update versions - #6274

Open
Saint-14-research wants to merge 1 commit into
pingdotgg:mainfrom
Saint-14-research:codex/restore-project-sidebar-and-update-contract
Open

Restore project thread trees and align desktop update versions#6274
Saint-14-research wants to merge 1 commit into
pingdotgg:mainfrom
Saint-14-research:codex/restore-project-sidebar-and-update-contract

Conversation

@Saint-14-research

@Saint-14-research Saint-14-research commented Aug 12, 2026

Copy link
Copy Markdown

Summary

  • make expandable per-project thread trees the default sidebar while retaining the flat view as an opt-out
  • prefer a matching packaged desktop CLI for SSH-hosted sessions to prevent client/server schema skew
  • give local desktop artifacts the canonical update feed and keep packaged version producers aligned at 0.0.33

Verification

  • 86 focused tests passed across settings, SSH runner, desktop artifact, and release-version synchronization
  • contracts, SSH, desktop, and web typechecks passed
  • packaged macOS artifact reports 0.0.33 in Info.plist, rendered Settings, and bundled t3 --version
  • identical app.asar verified on MacBook Air and Mac mini

Scope

Only the 12 files relevant to this change are included; unrelated dirty working-tree changes were intentionally excluded.


Note

Medium Risk
Changes a user-facing default for all clients and alters SSH remote CLI resolution, which can affect remote session startup and version compatibility. Packaging/update-feed tweaks are lower risk but touch release paths.

Overview
Makes expandable per-project thread trees the default sidebar again (legacySidebarEnabled defaults to true), with the flat list kept as an explicit opt-out. Settings copy and tests are updated to match.

For packaged macOS apps, SSH remote sessions now prefer a version-matched installed desktop CLI (via ELECTRON_RUN_AS_NODE) before falling back to npx/npm, reducing client/server schema skew.

Also bumps packages to 0.0.33, defaults local desktop builds to the canonical GitHub update feed, and reuses the prebuilt production icon.icns when staging Mac icons.

Reviewed by Cursor Bugbot for commit 66a0df1. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Restore project thread trees as default sidebar and add desktop CLI path for remote SSH runner

  • Changes legacySidebarEnabled default from false to true in ClientSettingsSchema, making the expandable per-project thread tree the default sidebar for all clients without an explicit setting.
  • Extends the SSH remote runner script to prefer an installed desktop CLI (matched by version) before falling back to a global t3 install or package-based execution, using ELECTRON_RUN_AS_NODE to invoke the Electron binary as a Node process.
  • On macOS packaged builds, resolveDesktopSshCliRunner now includes a desktopCli descriptor in the runner options, pointing at the installed app's Electron executable and server entry.
  • Production mac desktop builds now use a pre-built icon.icns from apps/desktop/resources/icon.icns instead of generating one from a PNG; local builds without repo env vars default to the pingdotgg/t3code GitHub repository for update config.
  • Behavioral Change: the sidebar now defaults to the project tree view; users who preferred the flat list must explicitly opt out.

Macroscope summarized 66a0df1.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d337443-0ff7-4ed0-b82f-868c9d124543

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 66a0df1. Configure here.

// The original per-project tree remains the default because it preserves
// project context and lets users expand each project into its threads. The
// flat sidebar stays available as an explicit opt-out through this setting.
legacySidebarEnabled: Schema.Boolean.pipe(Schema.withDecodingDefault(Effect.succeed(true))),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar flashes wrong default

Medium Severity

Flipping legacySidebarEnabled to default true leaves useLegacySidebarEnabled gating with settingsHydrated && legacySidebarEnabled, which still forces false until hydration. Most users briefly mount the flat sidebar, then remount the project-tree sidebar once settings load.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 66a0df1. Configure here.

@macroscopeapp

macroscopeapp Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR changes the default sidebar UI for all users and adds new desktop CLI detection logic. An unresolved review comment identifies a potential sidebar flash bug during hydration that should be addressed before merging.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant