fix(web): open modified PR clicks in browser - #6278
Merged
Merged
Conversation
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Contributor
ApprovabilityVerdict: Approved a8a6b1d Simple UX fix adding standard web behavior for cmd/ctrl+click to open PR links in the browser. The change is minimal, well-tested, and follows expected conventions. You can customize Macroscope's approvability policy. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 12, 2026
## What's Changed * fix(web): align update toast release notes link by @t3-code[bot] in pingdotgg/t3code#6322 * fix(web): render tooltips above dropdowns by @extoci in pingdotgg/t3code#6241 * fix(web): open modified PR clicks in browser by @t3-code[bot] in pingdotgg/t3code#6278 * Fix mobile command popover glass rendering by @juliusmarminge in pingdotgg/t3code#6370 * test(mobile): seed snoozed showcase threads by @PixPMusic in pingdotgg/t3code#5155 * fix(web): preserve appearance mode when changing themes by @extoci in pingdotgg/t3code#6343 * feat(connect): deregister account environments from any client by @StiensWout in pingdotgg/t3code#4844 * feat(web): pull request surfaces — filters & qualifiers, all-server listing, update branch, reactions, in-place editing, smarter diffs by @Bil0000 in pingdotgg/t3code#6039 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1077...v0.0.34-nightly.20260812.1079 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
testing
vp test apps/web/src/lib/openPullRequestLink.test.tstsgo --noEmit -p apps/web/tsconfig.jsonvp lint apps/web/src/lib/openPullRequestLink.ts apps/web/src/lib/openPullRequestLink.test.tsvp fmt --check apps/web/src/lib/openPullRequestLink.ts apps/web/src/lib/openPullRequestLink.test.tsrequest provenance
mariaon Discord)Note
Low Risk
Small UX change to shared PR link click handling with unit tests; no auth, data, or security-sensitive logic.
Overview
Cmd/Ctrl-click on pull request links now opens them in the external browser, while ordinary clicks still use the in-app pull request view.
Adds
shouldOpenPullRequestExternallyand wires it intouseOpenChangeRequestLinkso modified clicks skip in-app handling and fall through to the browser. Behavior applies everywhere that shared handler is used (sidebar, toolbar, and markdown links).Reviewed by Cursor Bugbot for commit a8a6b1d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Allow modified PR link clicks to open in the browser instead of in-app
Adds
shouldOpenPullRequestExternallyto openPullRequestLink.ts, which returnstruewhenmetaKeyorctrlKeyis held. TheuseOpenChangeRequestLinkhook now checks this early and returnsfalsewithout performing internal navigation, letting the browser handle the click normally.Macroscope summarized a8a6b1d.