Skip to content

Stabilize Undici socket handling on macOS - #61

Merged
backnotprop merged 2 commits into
mainfrom
codex/repair-undici-macos-ci
Sep 14, 2026
Merged

backnotprop merged 2 commits into
mainfrom
codex/repair-undici-macos-ci

Conversation

@backnotprop

Copy link
Copy Markdown
Contributor

Summary

  • apply upstream Undici PR #5547 to the pinned 7.29.0 dependency through pnpm patchedDependencies
  • treat socket QoS marking as best effort so macOS EINVAL cannot abort an otherwise successful Cloudflare suite
  • carry the patch through local-package and OCI frozen-install boundaries
  • keep the patch removable once Miniflare moves to a fixed Undici release

Why

Both recent main runs completed all 316 core tests and all 37 Cloudflare tests, then intermittently failed on an unhandled setTypeOfService EINVAL from Undici on macOS. PR runs passed, confirming a platform/socket-state race.

Upstream: nodejs/undici#5547

Verification

  • pnpm install --frozen-lockfile
  • pnpm check:cloudflare
  • pnpm test:local-package
  • pnpm test:compact-compose
  • pnpm verify:iteration

@backnotprop
backnotprop merged commit b2b8548 into main Sep 14, 2026
8 checks passed
@backnotprop
backnotprop deleted the codex/repair-undici-macos-ci branch September 14, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant