Conversation
Contributor
|
Thanks, both pieces work. Two requests before merge:
Happy to merge the clear-all as soon as it's on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cas a document-level clear action in browse modey/Enterconfirmation, withn/EsccancellationMotivation
The existing
xaction removes annotations from the selected block, but there is no efficient way to reset all annotations for the currently open document.Wide rendered tables were also clipped at the document viewport. The new layout allocates a narrower width to each column, wraps each cell independently, preserves box-drawing borders, and keeps source offsets on the wrapped content. If any cell in a table wraps, the whole table switches to a full grid so every logical row remains visually separated; tables with no wrapping stay compact.
Effect
The fixture uses CJK and wide characters; the comparison below uses ASCII labels so the
GitHub code block itself does not introduce another display-width variable.
Before — the rendered row exceeds the viewport and the right side is clipped:
After — columns are fitted, cells wrap independently, and a wrapped table uses a full grid:
Verification
cargo fmt --allcargo clippy --workspace --all-targetscargo test --workspace— 126 tests passedcargo build --release -p plannotator-tui