Fix/auto commit contract and test discovery - #117
Open
MrTango wants to merge 2 commits into
Open
Conversation
run_evals.py passes --no-git on every case, so the default auto-commit path had no coverage. run_git_evals.py runs the same commands with git enabled and asserts, after each one, that the project is a repository, that git status --porcelain is empty, and that the expected commit was created. 25 cases: create x 3, skill install --scope project, setup, and every subtemplate plus zope_instance. Writes to workspaces-git/ and results-git/.
- setup now passes git_commit=config.auto_commit and not no_git, accepts --no-git, carries a chained --no-git from create, and echoes the commit message. It used to git init and commit even with auto_commit = false. - skill install/update --scope project commits the installed skills, so the project is not left dirty for the next add. New git.commit_paths() commits only those paths: it never runs git init and never stages unrelated changes. - The integration tests resolve the copier-templates checkout through tests.helpers.find_templates_checkout(), which knows this repo's develop/plone/src/copier-templates and the configured clone. Without it a plain "pytest -m integration" reported 1 passed / 2 skipped instead of 24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.