Skip to content

Adding decomposed FoKL GPs into PyBOP - #978

Open
derek-slack wants to merge 13 commits into
pybop-team:developfrom
derek-slack:develop
Open

Adding decomposed FoKL GPs into PyBOP#978
derek-slack wants to merge 13 commits into
pybop-team:developfrom
derek-slack:develop

Conversation

@derek-slack

Copy link
Copy Markdown

Description

This push adds the ability to create FoKL GPs as parameter functions of the state of the cell.

Fixes # 672

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
All tests pass: nox -s tests
The documentation builds: nox -s doctest
Code is commented for hard-to-understand areas
Tests added that prove fix is effective or that feature works

@derek-slack

Copy link
Copy Markdown
Author

I fixed the issue where the end user needed to use indices to call function inputs instead of strings:

User can now select from the set of passed children to the function by referencing the string in the Arguments options i.e:
GP_options = {'Arguments': ['Concentration in electrolyte [mol.m-3]']}
or similarly for division arguments:
GP_options = {'Arguments': [['Concentration in electrode [mol.m-3]',['Maximum concentration in electrode [mol.m-3]']]}

Comment thread pyproject.toml Outdated
Co-authored-by: NicolaCourtier <45851982+NicolaCourtier@users.noreply.github.com>
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.78862% with 217 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (3171a07) to head (b8b9163).
⚠️ Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/parameters/gp_parameter.py 11.42% 217 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #978      +/-   ##
===========================================
- Coverage    92.13%   90.06%   -2.08%     
===========================================
  Files           74       85      +11     
  Lines         5799     7023    +1224     
===========================================
+ Hits          5343     6325     +982     
- Misses         456      698     +242     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants