chore: Clean up python 2 legacy - #796
Open
ThosRTanner wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 96.65% 95.46% -1.19%
==========================================
Files 27 27
Lines 3554 3858 +304
==========================================
+ Hits 3435 3683 +248
- Misses 119 175 +56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ThosRTanner
force-pushed
the
issue/788/cleanup-python-2
branch
2 times, most recently
from
August 23, 2026 19:35
72bdc56 to
e05442d
Compare
Fixes python-zk#788 Remove python2 specific code Use python 3 style for constructors etc Use python3.8 techniques in a few places
ThosRTanner
force-pushed
the
issue/788/cleanup-python-2
branch
from
August 23, 2026 19:36
e05442d to
075c81a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788
Remove python2 specific code
Use python 3 style for constructors etc
Use python3.8 techniques in a few places
Why is this needed?
Code cleanup. This moves off deprecated python constructs (such as
class X(object))Proposed Changes
class X(object):toclass X:super(Class, self)tosuper()EINTRfrom __future__ import absolute_import(an early python 3-ism)Does this PR introduce any breaking change?
No
Coverage changes
These appear to be because it's based on 2 commits ago on master, rather than current master. This change actually increases coverage because there's now coverage of the
InterruptedExceptionpath inutils.py