gh-155006: Encode an error handler's replacement strictly - #155008
Merged
serhiy-storchaka merged 1 commit intoAug 2, 2026
Conversation
Encoding it with the same error handler could never terminate: a replacement that is itself unencodable calls the handler again. A replacement that does not fit is now reported against the input character. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
strreplacement was re-encoded with the same error handler, so a replacement that is itself unencodable called the handler again, without end. It is encoded strictly now, and one that does not fit is reported against the input character.replacetherefore raises where it used to recurse, which includes the charsets with no'?'at all, 38 of the names here: E13B, Braille, the INIS subsets and others.ignoreis unaffected.Encoding
a😀bwith the four handlers recursed for 274 encodings and for none now. The test fails without the change.The iconv codecs are new in 3.16, so there is no NEWS entry.