gh-155193: Add missing canonical parameter to urlsafe_b64decode() - #155197
Closed
VITA2aishu wants to merge 1 commit into
Closed
gh-155193: Add missing canonical parameter to urlsafe_b64decode()#155197VITA2aishu wants to merge 1 commit into
VITA2aishu wants to merge 1 commit into
Conversation
The what's new entry for 3.15 documents canonical=False being added to b32decode(), b32hexdecode(), b64decode(), urlsafe_b64decode(), a85decode(), b85decode(), and z85decode() (pythongh-146311), but urlsafe_b64decode() did not actually receive the parameter. Add canonical=False to urlsafe_b64decode()'s signature and pass it through to binascii.a2b_base64(), consistent with b64decode(). The default preserves existing behavior.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
PRs attempting to merge a maintenance branch into the main branch are deemed to be spam and automatically closed. If you were attempting to report a bug, please go to https://github.com/python/cpython/issues; see devguide.python.org for further instruction as needed. |
Member
|
Hmm, well that's a bug. However, please don't open PRs before a decision is made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The what's new entry for 3.15 documents canonical=False being added to b32decode(), b32hexdecode(), b64decode(), urlsafe_b64decode(), a85decode(), b85decode(), and z85decode() (gh-146311), but urlsafe_b64decode() did not actually receive the parameter.
Add canonical=False to urlsafe_b64decode()'s signature and pass it through to binascii.a2b_base64(), consistent with b64decode(). The default preserves existing behavior.
base64module #155193