gh-64502: Support several optional groups on the same level in Argument Clinic - #155210
Merged
serhiy-storchaka merged 3 commits intoAug 5, 2026
Merged
Conversation
…Argument Clinic Groups on the same nesting level, like in "[y, x,] [n,] attr", can now be omitted independently of each other. A group is now identified by a unique number instead of its nesting level. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
August 5, 2026 06:41
They were emitted in the iteration order of a set of group identifiers. The identifiers of the groups before the required parameters are small negative integers, -1 and -2 have the same hash, so their order depended on the size of Py_hash_t, and the code generated on a 32-bit platform differed from the checked in one. They are now emitted in the order of the parameters. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts: # Tools/clinic/libclinic/clanguage.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional groups on the same nesting level, like in
[y, x,] [n,] attr, can now be omitted independently of each other.Only nested groups were supported before.
_curses.window.chgatis such a function: it accepts(attr),(n, attr),(y, x, attr)and(y, x, n, attr), and no nesting of groups can express this set.A group is now identified by a unique number instead of its nesting level.