gh-155212: List the converters defined in a C file - #155221
Merged
serhiy-storchaka merged 2 commits intoAug 5, 2026
Merged
Conversation
The --converters option now accepts file names and can be used with --make. It parses the specified files, without writing anything, and prints the converters and return converters which they define, instead of the built-in ones. Legacy converters whose format unit does not start with a letter, like those defined in Modules/posixmodule.c, were silently omitted from the list; they are now printed on a separate line. A directory passed as a file name raised IsADirectoryError instead of reporting an error, in every mode. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
August 5, 2026 08:16
Opening a directory fails with IsADirectoryError on Unix, but with PermissionError on Windows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--convertersnow accepts file names and can be used with--make.It parses the specified files, without writing anything, and prints the converters and return converters which they define, instead of the built-in ones.
Two other changes:
Modules/posixmodule.c, were silently omitted from the list.IsADirectoryErrorinstead of reporting an error, in every mode.