gh-64502: Convert curses methods with optional groups to Argument Clinic - #155229
Merged
serhiy-storchaka merged 1 commit intoAug 5, 2026
Merged
Conversation
…nt Clinic chgat(), getstr(), instr(), get_wstr(), in_wstr() and in_wchstr() were parsing their arguments by hand, because Argument Clinic did not support their signatures. Their helper for parsing the optional y, x and n arguments is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chgat(),getstr(),instr(),get_wstr(),in_wstr()andin_wchstr()were parsing their arguments by hand, because Argument Clinic did not support their signatures.chgat()needs two optional groups on the same level ([y, x,] [n=-1,] attr), the other five need a parameter with a default value after an optional group ([y, x,] n=2047).Their helper for parsing the optional
y,xandnarguments is no longer needed.