Skip to content

Add mask support to cadence softmax (#21596) - #21596

Open
DrJessop wants to merge 1 commit into
pytorch:mainfrom
DrJessop:export-D114671838
Open

Add mask support to cadence softmax (#21596)#21596
DrJessop wants to merge 1 commit into
pytorch:mainfrom
DrJessop:export-D114671838

Conversation

@DrJessop

@DrJessop DrJessop commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary:

The kernel supports masking, need to support it in the reference as well.

Reviewed By: aliafzal

Differential Revision: D114671838

@pytorch-bot

pytorch-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21596

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 5a89d6f with merge base bb6b99a (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2026
@meta-codesync

meta-codesync Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114671838.

Summary:

The kernel supports masking, need to support it in the reference as well.

Reviewed By: aliafzal

Differential Revision: D114671838
@meta-codesync meta-codesync Bot changed the title Add mask support to cadence softmax Add mask support to cadence softmax (#21596) Aug 5, 2026
@DrJessop
DrJessop force-pushed the export-D114671838 branch from 8cbe126 to 5a89d6f Compare August 5, 2026 22:34
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants