Skip to content

[ExecuTorch][WebGPU] Support general groups=1 Conv1d - #21600

Open
JCNTH wants to merge 1 commit into
gh/JCNTH/207/basefrom
gh/JCNTH/207/head
Open

[ExecuTorch][WebGPU] Support general groups=1 Conv1d#21600
JCNTH wants to merge 1 commit into
gh/JCNTH/207/basefrom
gh/JCNTH/207/head

Conversation

@JCNTH

@JCNTH JCNTH commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Add a buffer-only groups=1 Conv1d kernel for Voxtral encoder shapes

The WebGPU backend handled only K=1 pointwise and depthwise Conv1d, leaving non-transposed groups=1 K=3 encoder convolutions unsupported.

Before

  • Groups=1 K>1 graphs had no valid WebGPU route.

After

  • A direct NCL buffer kernel supports groups=1 convolution with stride, padding, dilation, and optional bias.

Key changes:

  • add_conv1d_node — validates fp32 operands, geometry, shapes, and shader index ranges.
  • conv1d.wgsl — mirrors Vulkan output indexing in backends/vulkan/runtime/graph/ops/glsl/conv1d.glsl:78, stride/padding at :86, and the kernel FMA loop at :108.
  • Dispatch and resize hooks — fold x/y workgroups and recompute live parameters safely.
  • Generated sources — refresh WGSL headers, registry output, and drift digests.

The route remains limited to non-transposed groups=1 fp32 convolution; existing pointwise and depthwise routes are unchanged.

Co-authored-with: Claude Code.

Differential Revision: D114936145

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21600

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a17d304 with merge base ad3a71f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants