[ExecuTorch][WebGPU] Support general groups=1 Conv1d - #21600
Open
JCNTH wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21600
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a17d304 with merge base ad3a71f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 5, 2026
This was referenced Aug 5, 2026
This PR needs a
|
psiddh
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add a buffer-only groups=1 Conv1d kernel for Voxtral encoder shapes
The WebGPU backend handled only K=1 pointwise and depthwise Conv1d, leaving non-transposed groups=1 K=3 encoder convolutions unsupported.
Before
After
Key changes:
add_conv1d_node— validates fp32 operands, geometry, shapes, and shader index ranges.conv1d.wgsl— mirrors Vulkan output indexing inbackends/vulkan/runtime/graph/ops/glsl/conv1d.glsl:78, stride/padding at:86, and the kernel FMA loop at:108.The route remains limited to non-transposed groups=1 fp32 convolution; existing pointwise and depthwise routes are unchanged.
Co-authored-with: Claude Code.
Differential Revision: D114936145