Memory planning: Remove side effects from greedy algorithm - #21616
Open
Erik-Lundell wants to merge 1 commit into
Open
Memory planning: Remove side effects from greedy algorithm#21616Erik-Lundell wants to merge 1 commit into
Erik-Lundell wants to merge 1 commit into
Conversation
The result of a memory planning algorithm should be completely captured by the MemoryAlgoResult object. The greedy algorithm additionally mutated the TensorSpecs. This causes inference between algorithm when running multiple ones, and is an unclear division of responsibility. Just apply alignment outside the algorithm. Don't remove alignment args, to not change API of algorithms, which is outwards-facing. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I04ce2af0eff200ad0cc6aa2a583bcdd11b97b8ae
Erik-Lundell
requested review from
JacobSzwejbka and
larryliu0820
as code owners
August 6, 2026 12:18
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21616
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Cancelled Jobs, 1 PendingAs of commit ef481bd with merge base 4b4df96 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Erik-Lundell
added
ciflow/trunk
release notes: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of a memory planning algorithm should be completely captured by the MemoryAlgoResult
object. The greedy algorithm additionally mutated
the TensorSpecs. This causes inference between
algorithm when running multiple ones, and is
an unclear division of responsibility.
Just apply alignment outside the algorithm.
Don't remove alignment args, to not change API of
algorithms, which is outwards-facing.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani