Add unique #id to each session in course page - #69
Open
Kobzol wants to merge 1 commit into
Open
Conversation
encukou
reviewed
Aug 15, 2026
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
Sorry for missing the notification on this :(
It makes sense; I'd just namespace the ID:
| {% for session in course.sessions.values() %} | ||
|
|
||
| <div class="section{{ loop.index }}"> | ||
| <div class="section{{ loop.index }}" id="{{ session.slug }}"> |
Member
There was a problem hiding this comment.
Suggested change
| <div class="section{{ loop.index }}" id="{{ session.slug }}"> | |
| <div class="section{{ loop.index }}" id="session-{{ session.slug }}"> |
This allows us to provide permalinks to individual sessions.
Kobzol
force-pushed
the
course-session-id
branch
from
August 15, 2026 19:01
256e5f9 to
ae76cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to provide permalinks to individual sessions.
Note that we don't want to just link to the individual session page, because it does not contain all the materials. For example, if you take a look here, the main page also contains additional materials for each session, including video links. But if you open the page for the specific session, the video links are no longer there.
It can also be a bit easier to understand for people "where are they" if they see the lesson in the context of the whole course page, rather than just seeing a page containing only a single session.