Skip to content

Fix while_loop hint, update pragma hint in visitor.py - #371

Open
micpap25 wants to merge 1 commit into
qBraid:mainfrom
micpap25:patch-1
Open

Fix while_loop hint, update pragma hint in visitor.py#371
micpap25 wants to merge 1 commit into
qBraid:mainfrom
micpap25:patch-1

Conversation

@micpap25

Copy link
Copy Markdown
Contributor

Summary of changes

Fixes a mistake introduced by #346, which claims that visitor:_visit_while_loop is affected by self._check_only.
Additionally, updates the docstring of visitor:_visit_pragma to match the rest of the file.

Updated type hints for method arguments and return types in visitor.py.
@micpap25
micpap25 requested a review from TheGupta2012 as a code owner August 16, 2026 22:00
@argus-eye

argus-eye Bot commented Aug 16, 2026

Copy link
Copy Markdown

Argus review

Auto-review is off for this repo. Tick the box below to run a review on this PR.

  • Trigger Argus review

Estimated cost

  • Files changed: 1
  • Diff lines (±): 8
  • Historical avg: ~243.6k tokens · ~$0.95 · across last 10 review(s)

Tip: you can also comment @argus-eye review at any time.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey there! It looks like the changelog might need an update.

Please take a moment to edit the CHANGELOG.md with:

  • A brief, one-to-two sentence summary of your changes.
  • A link back to this PR for reference.
  • (Optional) A small working example if you've added new features.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ae37e3c1-a52d-405e-9122-5bda0ad1da16

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread src/pyqasm/visitor.py

Args:
statement (qasm3_ast.Pragma): The Pragma node to visit.
statement (Pragma): The Pragma node to visit.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be left as is, see the other methods

@TheGupta2012 TheGupta2012 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment, but should be okay to merge

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants