feat: add ability to sort cols on set list page - #563
Open
btfcookies wants to merge 2 commits into
Open
Conversation
Member
|
in client/scripts/utilities/tables.js there's a sortTable function, please use that instead |
Contributor
Author
|
resolved in a476a2c |
Member
|
so i discovered that my O(n^2) sorting algorithm breaks on this table, oops (at least i think thats why its laggy in test)... |
Contributor
Author
|
is this sort algorithm in the repo? if so i cant attempt to fix it |
Member
|
I hope you mean you can It's under client/scripts/utilities/tables.js |
Contributor
Author
|
Yes i did mean can sorry typo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #519
Adds bidirectional sort to columns in the set list page
tested locally