Skip to content

QCLINUX: arm64: dts: qcom: Add flag to enable aggregated CSIPHY - #1685

Open
Vishal Verma (vishverm-qli) wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
vishverm-qli:HP_dt_changes
Open

QCLINUX: arm64: dts: qcom: Add flag to enable aggregated CSIPHY#1685
Vishal Verma (vishverm-qli) wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
vishverm-qli:HP_dt_changes

Conversation

@vishverm-qli

Copy link
Copy Markdown

Add flag "aggregator-rx" to the Hamoa and Purwa camera dtsi.

This change enables the aggregated CSIPHY to enable the GMSL Camera and Per-port feature.

Add flag "aggregator-rx" to the Hamoa and Purwa camera dtsi.

This change enables the aggregated CSIPHY to enable the GMSL
Camera and Per-port feature.

Signed-off-by: Vishal Verma <vishverm@qti.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, knaveen-qc, Dmitry Baryshkov (lumag) and Trilok Soni (trsoni) and removed request for a team August 13, 2026 06:15
@qlijarvis

Copy link
Copy Markdown

PR #1685 — validate-patch

PR: #1685

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1685 - QCLINUX: arm64: dts: qcom: Add flag to enable aggregated CSIPHY
Upstream commit: N/A (vendor-only change)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear explanation of feature enablement
Fixes tag present/correct N/A Not a fix
Authorship preserved ⚠️ Email mismatch: From uses quic_vishverm@quicinc.com, Signed-off-by uses vishverm@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/hamoa-camera.dtsi Adds aggregator-rx; to 4 CSIPHY nodes (0,1,2,4)
arch/arm64/boot/dts/qcom/purwa-camera.dtsi Adds aggregator-rx; to 2 CSIPHY nodes (0,4)

Issues

  • Author email inconsistency: The From: field uses quic_vishverm@quicinc.com while Signed-off-by: uses vishverm@qti.qualcomm.com. These should match for proper git authorship tracking.

Verdict

Merge with minor fix recommended: unify the author email address across From: and Signed-off-by: fields. The technical content is correct for a vendor-specific devicetree change.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not checked — QCLINUX: vendor-only commit (integration_presence_report shows missing, but this is informational only for vendor commits)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Add flag to enable aggregated missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1685 — checker-log-analyzer

PR: #1685
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31673165106

Checker Result Summary
Checker Result Summary
checkpatch Email address mismatch in From:/Signed-off-by:
dt-binding-check ⏭️ No binding changes
dtb-check Passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No C/H file changes
check-patch-compliance QCLINUX: prefix not accepted
tag-check Subject has valid prefix (target: tech/overlay/dt)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1685 - QCLINUX: arm64: dts: qcom: Add flag to enable aggregated CSIPHY
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31673165106

Checker Result Summary
checkpatch Email address mismatch in From:/Signed-off-by:
dt-binding-check ⏭️ No binding changes
dtb-check Passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No C/H file changes
check-patch-compliance QCLINUX: prefix not accepted
tag-check Subject has valid prefix (target: tech/overlay/dt)

❌ checkpatch

Root cause: Email address mismatch between From: header and Signed-off-by: trailer.

Failure details:

WARNING: From:/Signed-off-by: email address mismatch: 
  'From: Vishal Verma <quic_vishverm@quicinc.com>' != 
  'Signed-off-by: Vishal Verma <vishverm@qti.qualcomm.com>'

be2d256deaba94b0b03078272323902981dc02e7 total: 0 errors, 1 warnings, 0 checks, 42 lines checked

The commit author email (quic_vishverm@quicinc.com) does not match the Signed-off-by: email (vishverm@qti.qualcomm.com).

Fix: Align the email addresses. Either:

  1. Update the commit author to match the Signed-off-by::

    git rebase -i <base_sha>   # mark commit as 'edit'
    git commit --amend --author="Vishal Verma <vishverm@qti.qualcomm.com>"
    git rebase --continue
  2. Or update the Signed-off-by: to match the From::

    git rebase -i <base_sha>   # mark commit as 'edit'
    # Edit commit message to change Signed-off-by: to quic_vishverm@quicinc.com
    git commit --amend
    git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 49dbe0dae5cf..be2d256deaba

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add flag to enable aggregated CSIPHY
Commit summary does not start with a required prefix

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

This is a known limitationQCLINUX: is a valid vendor-internal prefix used in the tree, but the checker enforces upstream-linkable prefixes only. For vendor-only commits with no upstream equivalent, this checker will always fail.

Fix: This is not a blocker if the change is genuinely vendor-specific with no upstream equivalent. The QCLINUX: prefix is correct for vendor-only DTS additions. However, if this change could be posted upstream:

  1. Post the patch to the devicetree mailing list
  2. Change prefix to FROMLIST:
  3. Add Link: <lore-url> to the commit body

If this remains vendor-only, the failure is expected and can be ignored.

Reproduce locally:

# The checker will always fail for QCLINUX: prefixed commits
# This is a known checker limitation, not a patch defect

Verdict

1 blocker to fix before merge:

  • Fix the email address mismatch in checkpatch (author vs. Signed-off-by)

1 expected failure (not a blocker):

  • check-patch-compliance fails for QCLINUX: prefix — this is a known checker limitation for vendor-only commits

All other checkers passed or were correctly skipped (no relevant file changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants