arm64: dts: qcom: sm8750: Add Pakala (Adreno 830) GPU DT nodes by quic-ksanadhy · Pull Request #1702 · qualcomm-linux/kernel-topics

quic-ksanadhy · 2026-08-17T11:27:53Z

Add Device Tree support for the Adreno 830 GPU on the Pakala (SM8750) SoC.

FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU nodes
FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes
FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling
FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 GPU
FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 GPU

CRs-Fixed: 4647429

amd_ntb_link_disable() prints "Enabling Link" which is misleading. Update the message to reflect that the link is being disabled. Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>

…hare BAR When BAR_PEER_SPAD and BAR_CONFIG share one PCI BAR, the module teardown path ends up calling pci_iounmap() on the same iomem with some offset, which is unnecessary and triggers a kernel warning like the following: Trying to vunmap() nonexistent vm area (0000000069a5ffe8) WARNING: mm/vmalloc.c:3470 at vunmap+0x58/0x68, CPU#5: modprobe/2937 [...] Call trace: vunmap+0x58/0x68 (P) iounmap+0x34/0x48 pci_iounmap+0x2c/0x40 ntb_epf_pci_remove+0x44/0x80 [ntb_hw_epf] pci_device_remove+0x48/0xf8 device_remove+0x50/0x88 device_release_driver_internal+0x1c8/0x228 driver_detach+0x50/0xb0 bus_remove_driver+0x74/0x100 driver_unregister+0x34/0x68 pci_unregister_driver+0x34/0xa0 ntb_epf_pci_driver_exit+0x14/0xfe0 [ntb_hw_epf] [...] Fix it by unmapping only when PEER_SPAD and CONFIG use difference bars. Cc: stable@vger.kernel.org Fixes: e75d5ae ("NTB: epf: Allow more flexibility in the memory BAR map method") Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Koichiro Den <den@valinux.co.jp> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>

Correct a function name and function parameter name to avoid kernel-doc warnings: Warning: include/linux/ntb.h:575 expecting prototype for ntb_default_port_count(). Prototype was for ntb_default_peer_port_count() instead Warning: include/linux/ntb.h:590 function parameter 'pidx' not described in 'ntb_default_peer_port_number' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>

The current list initialisation depends on the well hidden two zeros in the PCI_VDEVICE macro. Instead use a named initialisation that is more robust and easier to understand. Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>

Embedded Trace Router(ETR) is working as a DDR memory sink to collect tracing data from source device and the CTCU device serves as the control unit for the ETR device. Link: https://lore.kernel.org/all/20260204-enable-ctcu-and-etr-v3-3-0bb95c590ae1@oss.qualcomm.com/ Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>

…nel nt37801 The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801. Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> Link: https://lore.kernel.org/all/20260323102229.1546504-1-quic_amakhija@quicinc.com/ Signed-off-by: Arpit Saini <arpisain@qti.qualcomm.com>

The Inline Crypto Engine (ICE) exists as a standalone DT node, but the UFS node lacks the required qcom,ice phandle reference. Add the qcom,ice property to explicitly associate the UFS controller with its ICE instance. Fixes: d288abc ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC") Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/lkml/20260429-sm8750_ice_dt_fix-v1-1-2540dc337082@oss.qualcomm.com/ Signed-off-by: Kumar Kartik <kkartik@qti.qualcomm.com>

Add PSCI SYSTEM_RESET2 reboot-modes for sm8750-mtp and sm8750-qrd for use by the psci-reboot-mode driver. The following modes are defined: - bootloader: reboot into fastboot mode for fastboot flashing. - edl: reboot into emergency download mode for image loading via the Firehose protocol. Link: https://lore.kernel.org/r/20260529-psci_sys_reset-dt-changes-for-pakala-v2-1-1964ebf1924c@oss.qualcomm.com Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>

Add node for the SM8750 camera subsystem. Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-1-9fbb729fd242@oss.qualcomm.com/

Qualcomm SM8750 SoC has three Camera Control Interface (CCI). Each controller contains two I2C hosts. Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-2-9fbb729fd242@oss.qualcomm.com/

Define pinctrl definitions to enable camera master clocks on SM8750. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-3-9fbb729fd242@oss.qualcomm.com/

The traceNoC node used the "qcom,coresight-tnoc", "arm,primecell" compatible, which places the device on the AMBA bus. To bind an AMBA device, the bus reads the peripheral and component ID registers (PID/CID) at the top of the device's register block and matches them against the primecell ID. The traceNoC exposes the CID registers, but the Component ID value returned by the hardware is 0x00000000 instead of a valid AMBA Component ID, so the match never succeeds, the AMBA probe fails, and the device is left stuck in deferred probe indefinitely. Drop the "arm,primecell" entry and use the standalone "qcom,coresight-tnoc" compatible, which binds via the platform driver by compatible string and does not rely on the component ID register at all. This lets the device probe on hardware that does not return a valid CID, while remaining an Aggregator TNOC that retains ATID functionality. Link: https://lore.kernel.org/all/20260710-fix-tracenoc-probe-issue-v6-4-41eb36fef8d9@oss.qualcomm.com/ Fixes: ebd1eb3 ("arm64: qcom: dts: sm8750: add coresight nodes") Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>

Add Battery Current Limiting (BCL) hardware monitor node for pmih0108 PMIC. The BCL monitors battery voltage and current, providing hardware interrupts when configurable thresholds are violated. Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com> Link: https://lore.kernel.org/r/20260722-qcom-bcl-hwmon-v2-9-febe2805e17b@oss.qualcomm.com

qlijarvis · 2026-08-17T12:05:37Z

PR #1702 — validate-patch

PR: #1702

Verdict	Issues	Detailed Report
❌	6	Full report

Final Summary

Lore link present: No - all 5 commits with FROMLIST: prefix lack required Link: tags
Lore link matches PR commits: N/A - no lore links to compare against
Upstream patch status: N/A - cannot check upstream status without lore links
PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1702 - FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU nodes (5 commits)
Upstream commit: N/A (no lore.kernel.org links found)
Verdict: ❌ FAIL

Commit Message

Check Status Note

Subject matches upstream ❌ Cannot verify - no lore link provided

Body preserves rationale ❌ Cannot verify - no lore link provided

Fixes tag present/correct N/A No Fixes tags expected for new hardware enablement

Authorship preserved ❌ Cannot verify - no lore link to compare against

Backport note (if applicable) N/A Not a backport (FROMLIST prefix)

Diff

File Status Notes

arch/arm64/boot/dts/qcom/sm8750.dtsi ❌ Cannot verify against upstream - no lore link

arch/arm64/boot/dts/qcom/sm8750-mtp.dts ❌ Cannot verify against upstream - no lore link

arch/arm64/boot/dts/qcom/sm8750-qrd.dts ❌ Cannot verify against upstream - no lore link

Issues

Critical: Missing lore.kernel.org links

All 5 commits use the FROMLIST: prefix but lack the required Link: tag pointing to the lore.kernel.org posting. Per the validate-patch skill requirements and kernel submission guidelines:

Commit 1/5: FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU - no Link tag

Commit 2/5: FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes - no Link tag

Commit 3/5: FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling - no Link tag

Commit 4/5: FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 - no Link tag

Commit 5/5: FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 - no Link tag

The FROMLIST: prefix explicitly indicates these patches were posted to a mailing list but not yet merged upstream. Each commit must include a Link: https://lore.kernel.org/r/<message-id> tag to reference the upstream posting.

Authorship concerns:

Commit 1/5: Uses Co-developed-by: Taniya Das - this may be correct if Taniya genuinely co-authored the patch, but without the lore link we cannot verify if this matches the upstream posting or if the primary author should be in From: instead.

Verdict

Do not merge. All 5 commits must be amended to add the required Link: tags before this PR can be validated.

Recommended Actions
Locate the upstream lore postings for each commit (search lore.kernel.org by subject line)
Add Link tags to each commit message:
Link: https://lore.kernel.org/r/<message-id>
Verify authorship matches the lore posting (especially commit 1/5 with Co-developed-by)

Re-run validation after amendments
Example amendment command:
git rebase -i HEAD~5
# Mark each commit for 'reword'
# Add the Link: tag before the Signed-off-by: lines
Final Summary

Lore link present: No - all 5 commits with FROMLIST: prefix lack required Link: tags

Lore link matches PR commits: N/A - no lore links to compare against

Upstream patch status: N/A - cannot check upstream status without lore links

PR present in qcom-next/topics: Fail - per integration_presence_report.md: 1/5 commits missing from both qcom-next and topics; 4/5 commits show only partial presence (subject or partial tree evidence found, but full change not verified)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/5 [PATCH 1/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

2/5 [PATCH 2/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

3/5 [PATCH 3/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

4/5 [PATCH 4/5] FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

5/5 [PATCH 5/5] FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/5
partial_commits: 4/5
missing_commits: 1/5
topics_checked_for_commits: 5/5
final_summary: PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-08-17T12:05:38Z

PR #1702 — checker-log-analyzer

PR: #1702
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32025207175

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All 5 commits passed with no style issues
dt-binding-check	⏭️	Skipped - no binding changes
dtb-check	✅	Passed - no new DTB validation errors
sparse-check	⏭️	Skipped - no C/H file changes
check-uapi-headers	⏭️	Skipped - no UAPI changes
check-patch-compliance	❌	5 commits missing Link: tags
tag-check	✅	All commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1702 - Add GPU support for SM8750 (Adreno 830)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32025207175

Checker Result Summary

checkpatch ✅ All 5 commits passed with no style issues

dt-binding-check ⏭️ Skipped - no binding changes

dtb-check ✅ Passed - no new DTB validation errors

sparse-check ⏭️ Skipped - no C/H file changes

check-uapi-headers ⏭️ Skipped - no UAPI changes

check-patch-compliance ❌ 5 commits missing Link: tags

tag-check ✅ All commits have valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: All 5 commits are tagged with FROMLIST: but are missing the required Link: trailer pointing to the upstream lore.kernel.org posting.

Failure details:
Checking commit: FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU nodes
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 GPU
No 'Link' found in commit message

Checking commit: FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 GPU
No 'Link' found in commit message
Fix: Add a Link: trailer to each commit message pointing to the lore.kernel.org URL where the patch was posted upstream.

For each commit:
git rebase -i <base_sha>   # mark each commit as 'edit'
git commit --amend         # add Link: https://lore.kernel.org/... to the commit body
git rebase --continue
The Link: tag should be placed in the commit message body (after the description, before or after Signed-off-by: trailers), in the format:
Link: https://lore.kernel.org/r/<message-id>
Reproduce locally:
cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea \
  --head <your-pr-head-sha>
Verdict

5 blockers to fix before merge — all commits require Link: tags pointing to their upstream lore.kernel.org postings. Once the Link: trailers are added, all checkers should pass.

qlijarvis · 2026-08-18T04:43:32Z

🔨 Build Failure Analysis — PR #1702

PR: #1702
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32099023816

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflicts (1003 files)	Multiple files	No	PR #1702 appears to be empty (0 bytes patch), but the CI workflow attempts to merge it on top of an integration branch that already includes `topic/tech/all/dt/pakala`. The merge operation fails with 1003 conflicts across the entire kernel tree, indicating the PR branch has diverged significantly from the integration baseline.

Verdict

This is not a compilation failure. The build failed during the merge phase before any compilation could occur. The PR itself contains no changes (empty patch), but the merge conflicts suggest the PR branch is based on an incompatible baseline compared to the integration branch (tag 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea + topic/tech/all/dt/pakala).

📎 Detailed analysis: build_job_detailed.md

qlijarvis · 2026-08-18T04:46:35Z

🔨 Build Failure Analysis — PR #1702

PR: #1702
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32099023816

#	Error	File:Line	PR-introduced?	Root Cause
N/A	Merge conflicts (1003 files)	Multiple files	No	Integration merge failure - not a compilation error

Verdict

This is not a compilation failure. The build failed during the git merge phase when attempting to integrate PR #1702 (branch tech/all/dt/pakala) into the integration branch based on commit 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea. The failure occurred before any compilation was attempted, with 1003 merge conflicts across the codebase. The PR patch file is empty, indicating this may be a merge/integration PR rather than a code change PR.

📎 Detailed analysis: Full report

Add the GPU_CC and GX_CC (brand new! as far as we're concerned, this is simply a separate block housing the GX GDSC) nodes, required to power up the graphics-related hardware. Make use of it by enabling the associated IOMMU as well. The GPU itself needs some more work and will be enabled later. Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Co-developed-by: Taniya Das <taniya.das@oss.qualcomm.com> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com> Link: https://lore.kernel.org/lkml/20260714-gpucc_dt_v6-v6-1-16bf5289572d@oss.qualcomm.com/#r

Adreno 830 GPU present in SM8750 chipset belongs to the A8x family of Adreno GPU. It is similar to Adreno 840 GPU with some meaningful differences like GMEM size, register file size etc. Describe A830 GPU and GMU nodes in SM8750 devicetree. Also, add the qfprom node to describe the GPU speedbin fuse register. Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com> Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/T/#m6fbc0b228215096af09673f94e53b4680182f9f8

Unlike the CPU, the GPU does not throttle its speed automatically when it reaches high temperatures. Set up GPU cooling by throttling the GPU speed when reaching 105°C. Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com> https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/T/#m6fbc0b228215096af09673f94e53b4680182f9f8

Enable GPU for sm8750-mtp platform and provide path for zap shader. Upstream-Status: Pending Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com> Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/T/#m6fbc0b228215096af09673f94e53b4680182f9f8

Enable GPU for sm8750-qrd platform and provide path for zap shader. Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com> Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/T/#m6fbc0b228215096af09673f94e53b4680182f9f8

ALOK TIWARI (aloktiwa) and others added 14 commits July 2, 2026 16:09

Linux 7.2-rc1

40b19af

FROMLIST: arm64: dts: qcom: sm8750: Add camss node

7f5c7fd

Add node for the SM8750 camera subsystem. Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260618-pakala-camera-v2-1-9fbb729fd242@oss.qualcomm.com/

qcomlnxci requested review from a team, Amit Kucheria (idlethread), knaveen-qc and Trilok Soni (trsoni) and removed request for a team August 17, 2026 11:30

quic-ksanadhy force-pushed the tech/all/dt/pakala branch from dde9a15 to b955770 Compare August 18, 2026 04:22

qcomlnxci requested a review from a team August 18, 2026 04:24

quic-kdybcio and others added 5 commits August 18, 2026 17:45

quic-ksanadhy force-pushed the tech/all/dt/pakala branch from b955770 to f0ce6d1 Compare August 18, 2026 12:19

Salendarsingh Gaud (sgaud-quic) force-pushed the tech/all/dt/pakala branch from 33ecf6f to 450d786 Compare August 18, 2026 18:22

Navigation Menu

Uh oh!

arm64: dts: qcom: sm8750: Add Pakala (Adreno 830) GPU DT nodes - #1702

arm64: dts: qcom: sm8750: Add Pakala (Adreno 830) GPU DT nodes#1702
quic-ksanadhy wants to merge 19 commits into
qualcomm-linux:tech/all/dt/pakalafrom
quic-ksanadhy:tech/all/dt/pakala

quic-ksanadhy commented Aug 17, 2026 •

edited

Loading

Uh oh!

qlijarvis commented Aug 17, 2026

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Recommended Actions

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Aug 17, 2026

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

Verdict

Uh oh!

qlijarvis commented Aug 18, 2026

Uh oh!

qlijarvis commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

quic-ksanadhy commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qlijarvis commented Aug 17, 2026

PR #1702 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Recommended Actions

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Aug 17, 2026

PR #1702 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

Verdict

Uh oh!

qlijarvis commented Aug 18, 2026

🔨 Build Failure Analysis — PR #1702

Verdict

Uh oh!

qlijarvis commented Aug 18, 2026

🔨 Build Failure Analysis — PR #1702

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

quic-ksanadhy commented Aug 17, 2026 •

edited

Loading