Skip to content

BACKPORT: arm64: dts: qcom: Add Arduino Monza (VENTUNO Q) board support - #969

Draft
nkumarsi wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
nkumarsi:monza_qcom-6.18
Draft

BACKPORT: arm64: dts: qcom: Add Arduino Monza (VENTUNO Q) board support#969
nkumarsi wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
nkumarsi:monza_qcom-6.18

Conversation

@nkumarsi

@nkumarsi nkumarsi commented Aug 18, 2026

Copy link
Copy Markdown

Add device tree support for the Arduino VENTUNO Q board, based on the Qualcomm QCS8300 (Monaco) SoC.

This includes:

  • Monaco Monza SoM device tree support
  • Power and regulator configuration
  • PCIe, USB, Ethernet and display subsystem support
  • Arduino VENTUNO Q carrier board integration
  • Audio, HDMI, networking and GPIO-key support

@nkumarsi
BACKPORT: arm64: dts: qcom: Add Arduino Monza (VENTUNO Q) board support
bddd3c6 
Add device tree support for the Arduino VENTUNO Q board,
based on the Qualcomm QCS8300 (Monaco) SoC.

The board features a Qualcomm Monza SoM and integrates various
peripherals, including:
- USB Type‑C connector with dual‑role support
- ADV7535 DSI‑to‑HDMI bridge
- MAX98091 audio codec
- 2.5G Ethernet PHY (HSGMII)
- PCIe0 (to onboard WiFi chipset and USB bridge)
- PCIe1 (to M2/nvme)
- Button (via GPIO‑keys)

Link: https://lore.kernel.org/r/20260313103824.2634519-7-srinivas.kandagatla@oss.qualcomm.com

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Co-developed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
@nkumarsi
BACKPORT: arm64: dts: qcom: Add Monaco Monza SoM
1ea364b 
The Monaco Monza SoM is a compact computing module that integrates a
Monaco/QCS8300 System on Chip (SoC), along with essential components
optimized for IoT applications. It is designed to be mounted on
carrier boards, enabling the development of complete embedded systems.

The following components are described:
- Fixed S2S 1.8V rail
- PMM8654AU RPMh regulators (PMIC A and PMIC C)
- Display subsystem/phy supplies (DSI, DP)
- Enable GPU, GPI DMA, IRIS
- PCIe Gen4 for both controllers and PHY supply hookups
- QUPv3 firmware declarations
- REFGEN always-on workaround for USB2 HS PHY
- Remoteproc firmware names for ADSP, CDSP and GPDSP
- Ethernet SERDES supplies
- USB HS/SS PHY regulators
- On-SoM eMMC

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Co-developed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260313103824.2634519-5-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
@qswat-orbit-external

qswat-orbit-external Bot commented Aug 18, 2026

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

qswat-orbit-external Bot commented Aug 18, 2026

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

qlijarvis commented Aug 18, 2026

Copy link
Copy Markdown

PR #969 — validate-patch

PR: #969

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Yes — both commits have valid lore.kernel.org links
  2. Lore link matches PR commits: No — authorship changed from Loic Poulain to Nirmesh Kumar Singh; commit 1/2 combines multiple upstream patches (3/7 + 6/7)
  3. Upstream patch status: ✅ ACKed — Applied by Bjorn Andersson (Qualcomm DT maintainer) on March 18, 2026
  4. PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #969
Commits: 2 commits (both BACKPORT prefix)
Verdict: ❌ FAIL

Commit 1/2: BACKPORT: arm64: dts: qcom: Add Arduino Monza (VENTUNO Q) board support

Upstream: https://lore.kernel.org/r/20260313103824.2634519-7-srinivas.kandagatla@oss.qualcomm.com (patch 6/7 in series)

Commit Message

Check Status Note
Subject matches upstream ✅ Subject preserved correctly
Body preserves rationale ✅ Peripheral list and description match upstream
Fixes tag present/correct N/A No Fixes tag in upstream or PR
Authorship preserved ❌ CRITICAL: PR has From: Nirmesh Kumar Singh but upstream has From: Loic Poulain. For BACKPORT commits, original author MUST be preserved in From: field
Backport note ❌ Missing [ upstream commit <sha> ] note in commit body
Co-developed-by used correctly ✅ Srinivas Kandagatla correctly listed as co-developer

Diff Comparison

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ⚠️ Context differs (different baseline) but change is equivalent
arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts ✅ New file content matches upstream
arch/arm64/boot/dts/qcom/monaco.dtsi ❌ PR adds entire lpass_tlmm node (68 lines) but upstream patch 6/7 only adds pinctrl states inside existing node. PR is combining upstream patches 3/7 and 6/7 into one commit

Upstream Patch Status

✅ ACKed — Applied by Bjorn Andersson (maintainer) on March 18, 2026 with message "Applied, thanks!"
Series received Reviewed-by: from Konrad Dybcio and Dmitry Baryshkov.

Commit 2/2: BACKPORT: arm64: dts: qcom: Add Monaco Monza SoM

Upstream: https://lore.kernel.org/r/20260313103824.2634519-5-srinivas.kandagatla@oss.qualcomm.com (patch 4/7 in series)

Commit Message

Check Status Note
Subject matches upstream ✅ Subject preserved correctly
Body preserves rationale ✅ Component list and description match upstream
Fixes tag present/correct N/A No Fixes tag in upstream or PR
Authorship preserved ❌ CRITICAL: PR has From: Nirmesh Kumar Singh but upstream has From: Loic Poulain. For BACKPORT commits, original author MUST be preserved in From: field
Backport note ❌ Missing [ upstream commit <sha> ] note in commit body
Co-developed-by used correctly ✅ Srinivas Kandagatla correctly listed as co-developer

Diff Comparison

File Status Notes
arch/arm64/boot/dts/qcom/monaco-monza-som.dtsi ✅ New file content matches upstream patch 4/7

Upstream Patch Status

✅ ACKed — Applied by Bjorn Andersson (maintainer) on March 18, 2026 as part of the same series.

Issues Found

  1. Authorship violation (both commits): The From: field shows Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com> but the upstream lore patches have From: Loic Poulain <loic.poulain@oss.qualcomm.com>. For BACKPORT: commits, the original author MUST be preserved in the From:/Author: field. The submitter's Signed-off-by: should be added at the end, but the primary author must remain Loic Poulain.

  2. Missing backport note (both commits): BACKPORT commits should include a note like [ upstream commit <sha> ] in the commit body to reference the merged upstream commit. This is missing from both commits.

  3. Content mismatch (commit 1/2): The PR commit adds the entire lpass_tlmm pinctrl node (68 lines) to monaco.dtsi, but upstream patch 6/7 only adds pinctrl states inside an already-existing lpass_tlmm node. The PR is combining content from upstream patches 3/7 (which adds the lpass_tlmm node) and 6/7 (which adds pinctrl states) into a single commit. This is a squash of multiple upstream patches without proper attribution.

Verdict

Do not merge without correction. Both commits violate the authorship preservation requirement for BACKPORT commits. Additionally, commit 1/2 combines multiple upstream patches without proper documentation.

Recommended Fixes

  1. Fix authorship: Amend both commits to restore original author:

    git commit --amend --author="Loic Poulain <loic.poulain@oss.qualcomm.com>"

  2. Add backport notes: Once the upstream commits land in Linus's tree, add [ upstream commit <sha> ] notes to both commit bodies.

  3. Split commit 1/2: Consider splitting commit 1/2 into two separate commits:

    • First commit: BACKPORT of patch 3/7 (adds lpass_tlmm node)
    • Second commit: BACKPORT of patch 6/7 (adds pinctrl states)

    Or, if keeping as a single commit, document in the commit message that it combines patches 3/7 and 6/7 from the upstream series.

Final Summary

  1. Lore link present: Yes — both commits have valid lore.kernel.org links
  2. Lore link matches PR commits: No — authorship changed from Loic Poulain to Nirmesh Kumar Singh; commit 1/2 combines multiple upstream patches (3/7 + 6/7)
  3. Upstream patch status: ✅ ACKed — Applied by Bjorn Andersson (Qualcomm DT maintainer) on March 18, 2026
  4. PR present in qcom-next/topics: Yes — per integration_presence_report.md, both commits are present in qcom-next (commit 2/2 has exact patch-id match at 5238f4e7169fe908379ef991e320b1641c21fcbe)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] BACKPORT: arm64: dts: qcom: Add Arduino Monza (VENTUNO Q) present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
2/2 [PATCH 2/2] BACKPORT: arm64: dts: qcom: Add Monaco Monza SoM present - exact patch-id match at 5238f4e skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: PASS
present_commits: 2/2
partial_commits: 0/2
missing_commits: 0/2
topics_checked_for_commits: 0/2
final_summary: PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Aug 18, 2026

Copy link
Copy Markdown

PR #969 — checker-log-analyzer

PR: #969
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32100362465

Detailed report: Full report

Checker analysis — click to expand

@nkumarsi
nkumarsi marked this pull request as draft August 18, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardosalveti Ricardo Salveti (ricardosalveti) Awaiting requested review from ricardosalveti ricardosalveti was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@Komal-Bajaj Komal Bajaj (Komal-Bajaj) Awaiting requested review from Komal-Bajaj Komal-Bajaj was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@mukeshojha-linux Mukesh Ojha (mukeshojha-linux) Awaiting requested review from mukeshojha-linux mukeshojha-linux was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nkumarsi @qlijarvis