Skip to content

usb: typec: hd3ss3220: Fix VBUS regulator reference handling #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chang Wu (kunjinkao-os) wants to merge 2 commits into
base: qcom-6.18.y
Choose a base branch
from
+8 −3
Open

usb: typec: hd3ss3220: Fix VBUS regulator reference handling #972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7904cd8
UPSTREAM: usb: typec: hd3ss3220: fix VBUS regulator error message
Aug 12, 2026
12aa1d7
FROMLIST: usb: typec: hd3ss3220: track VBUS enable state per consumer
kunjinkao-os Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions drivers/usb/typec/hd3ss3220.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ struct hd3ss3220 {
int id_irq;

struct regulator *vbus;
bool vbus_enabled;
};

static int hd3ss3220_set_power_opmode(struct hd3ss3220 *hd3ss3220, int power_opmode)
Expand Down Expand Up @@ -208,17 +209,21 @@ static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on)
{
int ret;

if (regulator_is_enabled(hd3ss3220->vbus) == on)
if (hd3ss3220->vbus_enabled == on)
return;

if (on)
ret = regulator_enable(hd3ss3220->vbus);
else
ret = regulator_disable(hd3ss3220->vbus);

if (ret)
if (ret) {
dev_err(hd3ss3220->dev,
"vbus regulator %s failed: %d\n", on ? "disable" : "enable", ret);
"vbus regulator %s failed: %d\n", on ? "enable" : "disable", ret);
return;
}

hd3ss3220->vbus_enabled = on;
}

static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220)
Expand Down