chore(server): remove the billing plans boot loader flow by rohilsurana · Pull Request #1870 · raystack/frontier

rohilsurana · 2026-08-11T08:03:07Z

What

Removes the billing.plans_path boot loader end to end. Billing products, plans, prices, and features are managed through the reconcile flow now (the BillingProduct and BillingPlan kinds), so the server no longer reads a plans file at startup.

cmd/serve.go: drop the billing blob store and the MigrateBillingPlans call.
internal/bootstrap: drop the BillingPlanRepository and PlanService dependencies and the MigrateBillingPlans method.
billing/config.go: remove the plans_path field.
internal/store/blob/plan_repository.go: removed, no longer used.
config/sample.config.yaml: drop the sample entry.
test/e2e: the billing regression suite seeds the fixtures it needs (support_credits and enterprise_yearly) through the admin API in SetupSuite instead of the boot loader.

UpsertPlans and plan.File stay: the admin CreatePlan handler still uses them to create a plan with its products.

Why it is safe

Existing plans and products live in the database, so this is a no-op for a server that has already migrated. The reconcile flow (frontier reconcile with the BillingProduct / BillingPlan kinds) owns this state now.

Gating

This is the billing counterpart to #1767 (the resources_config boot loader removal). Same rule: a deployment must run the reconcile flow so plans and products are owned there, and drop plans_path from its own config, before taking this build.

One boot-time dependency to call out: if a deployment sets billing.customer.credit_overdraft_product (or billing.customer.default_plan), that product or plan must already exist in the database before the server starts. InvoiceService.Init resolves the overdraft product at boot and fails startup if it is missing, and EnsureDefaultPlan needs the default plan to exist. The boot loader used to seed these; now they must come from the reconcile flow or already be present. Deployments that already ran the loader in a past release have this data, so this is a no-op for them. A fresh install must seed the catalog through reconcile first.

Verification

go build ./..., go vet ./..., and unit tests for internal/bootstrap, billing/plan, core/event, and internal/api/v1beta1connect pass. gofmt and lint clean.

…oader

vercel · 2026-08-11T08:03:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
frontier	Ready	Preview	Aug 11, 2026 10:04am

coderabbitai · 2026-08-11T08:03:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e0060840-3cbb-49f3-a6dd-6fffd33772f3

📥 Commits

Reviewing files that changed from the base of the PR and between caa4a30 and 26001fb.

📒 Files selected for processing (3)

docs/content/docs/reference/billing-configurations.mdx
docs/content/docs/reference/configurations.mdx
test/e2e/testbench/testbench.go

💤 Files with no reviewable changes (2)

docs/content/docs/reference/configurations.mdx
docs/content/docs/reference/billing-configurations.mdx

📝 Walkthrough

Summary by CodeRabbit

Breaking Changes
- Removed support for configuring billing plans with billing.plans_path and YAML plan files.
- Billing plans are no longer loaded or migrated automatically during application startup.
Billing
- Billing products, prices, and plans can be provisioned through the database and administrative APIs.
Testing
- Billing test environments now seed products and prices before startup and create plans through the administrative API.
Documentation
- Removed references to the retired billing plans configuration.

Walkthrough

Changes

The PR removes YAML/blob-based billing plan loading from startup. Testbench initialization gains pre-start database seeders, and billing E2E tests create required products and plans through database and admin APIs.

Billing plan loading removal

Layer / File(s)	Summary
Remove startup plan loading `billing/config.go`, `config/sample.config.yaml`, `internal/bootstrap/service.go`, `cmd/serve.go`, `core/event/service_test.go`, `docs/content/docs/reference/*.mdx`	Removes `PlansPath`, billing plan repository wiring, bootstrap interfaces, `MigrateBillingPlans`, and related documentation.
Add pre-start database seeders `test/e2e/testbench/testbench.go`	Adds `PreStartSeeder` callbacks to `testbench.Init` and runs them after migrations and before Frontier starts.
Move billing E2E fixture setup `test/e2e/regression/billing_test.go`, `test/e2e/regression/testdata/plans/subscription.credits.yaml`	Seeds `support_credits` in PostgreSQL before startup and creates `enterprise_yearly` through the admin API after startup. Removes the YAML fixture.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

raystack/frontier#1767: Removes deprecated boot-time blob configuration loaders and related wiring.
raystack/frontier#1830: Moves billing plan creation and updates to database-backed admin APIs.

Suggested reviewers: whoabhisheksah

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coveralls · 2026-08-11T08:09:44Z

Coverage Report for CI Build 31480556679

Coverage increased (+0.07%) to 48.17%

Details

Coverage increased (+0.07%) from the base build.
Patch coverage: 1 uncovered change across 1 file (0 of 1 lines covered, 0.0%).
2 coverage regressions across 1 file.

Uncovered Changes

File	Changed	Covered	%
cmd/serve.go	1	0	0.0%

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
cmd/serve.go	2	0.0%

Coverage Stats


Relevant Lines:	39859
Covered Lines:	19200
Line Coverage:	48.17%
Coverage Strength:	15.39 hits per line

💛 - Coveralls

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 30aa3df8-3256-4193-b63e-a3f29da80747

📥 Commits

Reviewing files that changed from the base of the PR and between 8e22bcf and caa4a30.

📒 Files selected for processing (9)

billing/config.go
cmd/serve.go
config/sample.config.yaml
core/event/service_test.go
internal/bootstrap/service.go
internal/store/blob/plan_repository.go
test/e2e/regression/billing_test.go
test/e2e/regression/testdata/plans/subscription.credits.yaml
test/e2e/testbench/testbench.go

💤 Files with no reviewable changes (5)

config/sample.config.yaml
test/e2e/regression/testdata/plans/subscription.credits.yaml
internal/store/blob/plan_repository.go
internal/bootstrap/service.go
core/event/service_test.go

rohilsurana

Automated code review (xhigh). Findings below, most important first. The first two look like real boot/runtime regressions worth confirming before merge.

rohilsurana · 2026-08-11T09:56:05Z

-		logger.Info("migrated billing plans")
-	}
-
 	// apply roles over nil org id


Likely hard boot failure when credit_overdraft_product is set.

Removing the boot plan loader drops the only thing that seeded credit_overdraft_product before InvoiceService.Init. On a fresh database with billing.customer.credit_overdraft_product set, Init calls productService.GetByID(...), gets not-found, and returns failed to get credit overdraft product, so StartServer fails and the server never comes up. The e2e suite hides this with a new pre-start DB seeder, but production has no equivalent replacement.

Covered for our rollout: prod and staging set credit_overdraft_product by UUID, the product already exists in the DB and is in the reconcile billing-products export (behavior: credits), so Init resolves it at boot. Fresh installs must seed the catalog via reconcile first, which is now noted in the PR description. Leaving Init fail-fast rather than changing that core behavior in this PR.

rohilsurana · 2026-08-11T09:56:05Z

+	StripeKey            string                `yaml:"stripe_key" mapstructure:"stripe_key"`
+	StripeAutoTax        bool                  `yaml:"stripe_auto_tax" mapstructure:"stripe_auto_tax"`
+	StripeWebhookSecrets []string              `yaml:"stripe_webhook_secrets" mapstructure:"stripe_webhook_secrets"`
+	DefaultCurrency      string                `yaml:"default_currency" mapstructure:"default_currency"`


Plan/product seeding is removed with no replacement, and plans_path is now silently ignored.

For a deployment that defined its catalog via plans_path and set default_plan, the key is now an unknown field that config loading ignores. Nothing seeds the plans on boot, so EnsureDefaultPlan fails for every new org (only logged in listener.go, so the org comes up with no subscription or entitlements), and CreateCheckout fails plan-not-found for those plan names. Please confirm the reconcile/admin path fully covers this before merge.

Covered: pixxel sets no default_plan, and plans are owned by reconcile now. Removed the stale plans_path docs. plans_path being ignored is the intended removal; fresh-install ordering is noted in the PR description.

rohilsurana added 2 commits August 11, 2026 13:32

test(e2e): seed billing plans via the admin API instead of the boot l…

2b16573

…oader

chore(server): remove the billing plans boot loader flow

1c3cdbc

vercel Bot deployed to Preview August 11, 2026 08:03 View deployment

test(e2e): seed the credit overdraft product before the server starts

caa4a30

vercel Bot deployed to Preview August 11, 2026 09:16 View deployment

rohilsurana marked this pull request as ready for review August 11, 2026 09:18

coderabbitai Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread test/e2e/testbench/testbench.go Outdated

rohilsurana commented Aug 11, 2026

View reviewed changes

test(e2e): tear down containers when a pre-start seeder fails

26001fb

vercel Bot deployed to Preview August 11, 2026 10:04 View deployment

Navigation Menu

Uh oh!

chore(server): remove the billing plans boot loader flow - #1870

chore(server): remove the billing plans boot loader flow#1870
rohilsurana wants to merge 4 commits into
mainfrom
chore/remove-billing-plans-boot-loader

rohilsurana commented Aug 11, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

coveralls commented Aug 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

rohilsurana left a comment

Uh oh!

rohilsurana Aug 11, 2026

Uh oh!

rohilsurana Aug 11, 2026

Uh oh!

rohilsurana Aug 11, 2026

Uh oh!

rohilsurana Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rohilsurana commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why it is safe

Gating

Verification

Uh oh!

vercel Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

coveralls commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 31480556679

Coverage increased (+0.07%) to 48.17%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rohilsurana left a comment

Choose a reason for hiding this comment

Uh oh!

rohilsurana Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

rohilsurana Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

rohilsurana Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

rohilsurana Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rohilsurana commented Aug 11, 2026 •

edited

Loading

vercel Bot commented Aug 11, 2026 •

edited

Loading

coderabbitai Bot commented Aug 11, 2026 •

edited

Loading

coveralls commented Aug 11, 2026 •

edited

Loading