[iOS][Fabric] Reset keyboard inset state when recycling ScrollViews - #57791
Draft
RealBhupesh wants to merge 1 commit into
Draft
[iOS][Fabric] Reset keyboard inset state when recycling ScrollViews#57791RealBhupesh wants to merge 1 commit into
RealBhupesh wants to merge 1 commit into
Conversation
Fixes react#57755 Reset keyboard-managed state and cancel active animations when a Fabric ScrollView is recycled so later views cannot inherit keyboard insets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57755
Summary
Root cause
Fabric recycles RCTScrollViewComponentView instances while their keyboard notification observer remains registered. The keyboard opt-in flag and keyboard-managed indicator inset were not reset during recycling, so a later ScrollView could inherit keyboard behavior or an in-flight animation from the previous component.
Changelog:
[IOS] [FIXED] - Prevent keyboard inset state from leaking through recycled Fabric ScrollViews
Test Plan
./node_modules/.bin/clang-format --dry-run --Werror packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mmgit diff --check./node_modules/.bin/prettier --list-different "./**/*.{js,md,yml,ts,tsx}"