[VersionBonding] Allow a rule to require multiple composer package constraints at once - #8355
Merged
Merged
Conversation
…nstraints at once
TomasVotruba
enabled auto-merge (squash)
August 20, 2026 15:40
TomasVotruba
disabled auto-merge
August 20, 2026 15:41
Member
Author
|
Merging as CI fail unrelated: on composer install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables a version-bonded rule to declare more than one composer package constraint, all of which must be satisfied for the rule to run.
Why
Some rules only make sense when two packages are new enough at the same time. Example from rectorphp/rector#9856: the
#[AsTwigFilter]/#[AsTwigFunction]/#[AsTwigTest]attributes exist intwig/twig3.21, but Symfony only autoregisters extension-less classes built from them insymfony/twig-bridge7.3. A rule gated on twig alone fires on Symfony 6.4, stripsTwigExtension, and silently loses every filter/function.Until now
provideComposerPackageConstraint()could return a single constraint only.What
ComposerPackageConstraintInterface::provideComposerPackageConstraint()may now return either a singleComposerPackageConstraint(unchanged) or alist<ComposerPackageConstraint>. The return type widened toComposerPackageConstraint|array, so every existing implementer stays valid by covariance — no rule needs to change.The filter requires all constraints to be satisfied; a single miss (or missing package) skips the rule:
bin/rector composer-based(the debug table) now prints one row per constraint.The matching rule fix lives in a follow-up rector-symfony PR that depends on this one.