[TypeDeclarationDocblocks] Skip ClassMethodArrayDocblockParamFromLocalCallsRector on methods overriding parent/interface - #8357
Merged
Conversation
…lCallsRector on methods overriding parent/interface (#9835)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9835
ClassMethodArrayDocblockParamFromLocalCallsRectoradded a@paramdocblock inferred from local calls, even when the method overrides a parent/interface method whose contract is wider. This narrowed the type below the parent contract and broke LSP.Before
Interface declares a wide array shape:
Implementation only calls it locally with
['id' => ...], so the rule wrongly narrowed the docblock:final class SomeSearch implements SomeSearchInterface { + /** + * @param array<string, string> \$criteria + */ public function findOneMatching(array \$criteria): ?object { return null; } }After
The rule now skips a method when a parent class or interface already declares it (
ClassMethodManipulator::hasParentMethodOrInterfaceMethod()), keeping the wider contract intact.