[CodeQuality] Skip SimplifyUselessVariableRector on commented-out code and inline concat - #8468
Merged
TomasVotruba merged 3 commits intoSep 6, 2026
Merged
Conversation
…e and inline concat Do not inline a variable when commented-out code between assign and return mentions it, as it may be re-enabled later. Also stop merging compound assigns (.=, += ...) into the return, which worsens readability; only direct assigns are simplified now.
The AssignOp direction was only used by SimplifyUselessVariableRector, which no longer merges compound assigns; the sole caller now passes a BinaryOp.
TomasVotruba
deleted the
skip-useless-variable-comment-and-inline-concat
branch
September 6, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to
SimplifyUselessVariableRector:.=,+=, ...) into the return. Folding$xml .= '</RuleMessage>'; return $xml;intoreturn $xml . '</RuleMessage>';worsens readability. Only direct assigns are simplified now, so theonly_direct_assignoption and its non-direct branch are removed.