Skip to content

refactor(oxlint): enable no-undef - #44897

Open
secustor wants to merge 1 commit into
renovatebot:mainfrom
secustor:refactor/oxlint-no-undef
Open

refactor(oxlint): enable no-undef#44897
secustor wants to merge 1 commit into
renovatebot:mainfrom
secustor:refactor/oxlint-no-undef

Conversation

@secustor

Copy link
Copy Markdown
Member

Changes

Enables the no-undef rule at error. The rule was previously unusable because .oxlintrc.json declared no env/globals, so every reference to a runtime global was reported (36,672 diagnostics).

Adds the missing environment configuration:

  • Top level env: node (Node.js + CommonJS globals such as process, Buffer, console, require, module, __dirname, needed by lib/, tools/ and the .github scripts) and es2025, matching "lib": ["ES2025"] in tsconfig.json.
  • Test-only globals are scoped to the existing ["**/*.spec.ts", "test/**"] override instead of polluting the top level: the built-in vitest env covers describe, it, test, expect, expectTypeOf, vi, beforeEach/afterEach/ beforeAll/afterAll, mirroring "types": ["vitest/globals"].
  • The repo's own fixtures global, installed in test/setup.ts via Object.defineProperty(global, 'fixtures', ...), is declared as a readonly global in the same override.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

Enables the `no-undef` rule at `error`. The rule was previously
unusable because `.oxlintrc.json` declared no `env`/`globals`, so
every reference to a runtime global was reported (36,672 diagnostics).

Adds the missing environment configuration:

- Top level `env`: `node` (Node.js + CommonJS globals such as
  `process`, `Buffer`, `console`, `require`, `module`, `__dirname`,
  needed by `lib/`, `tools/` and the `.github` scripts) and `es2025`,
  matching `"lib": ["ES2025"]` in `tsconfig.json`.
- Test-only globals are scoped to the existing
  `["**/*.spec.ts", "test/**"]` override instead of polluting the top
  level: the built-in `vitest` env covers `describe`, `it`, `test`,
  `expect`, `expectTypeOf`, `vi`, `beforeEach`/`afterEach`/
  `beforeAll`/`afterAll`, mirroring `"types": ["vitest/globals"]`.
- The repo's own `fixtures` global, installed in `test/setup.ts` via
  `Object.defineProperty(global, 'fixtures', ...)`, is declared as a
  readonly global in the same override.

Full lint run over all 2,575 files reports zero diagnostics.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions
github-actions Bot requested a review from viceice July 27, 2026 22:49
@secustor
secustor requested review from a team and removed request for viceice July 27, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant