refactor(oxlint): enable no-undef - #44897
Open
secustor wants to merge 1 commit into
Open
Conversation
Enables the `no-undef` rule at `error`. The rule was previously unusable because `.oxlintrc.json` declared no `env`/`globals`, so every reference to a runtime global was reported (36,672 diagnostics). Adds the missing environment configuration: - Top level `env`: `node` (Node.js + CommonJS globals such as `process`, `Buffer`, `console`, `require`, `module`, `__dirname`, needed by `lib/`, `tools/` and the `.github` scripts) and `es2025`, matching `"lib": ["ES2025"]` in `tsconfig.json`. - Test-only globals are scoped to the existing `["**/*.spec.ts", "test/**"]` override instead of polluting the top level: the built-in `vitest` env covers `describe`, `it`, `test`, `expect`, `expectTypeOf`, `vi`, `beforeEach`/`afterEach`/ `beforeAll`/`afterAll`, mirroring `"types": ["vitest/globals"]`. - The repo's own `fixtures` global, installed in `test/setup.ts` via `Object.defineProperty(global, 'fixtures', ...)`, is declared as a readonly global in the same override. Full lint run over all 2,575 files reports zero diagnostics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enables the
no-undefrule aterror. The rule was previously unusable because.oxlintrc.jsondeclared noenv/globals, so every reference to a runtime global was reported (36,672 diagnostics).Adds the missing environment configuration:
env:node(Node.js + CommonJS globals such asprocess,Buffer,console,require,module,__dirname, needed bylib/,tools/and the.githubscripts) andes2025, matching"lib": ["ES2025"]intsconfig.json.["**/*.spec.ts", "test/**"]override instead of polluting the top level: the built-invitestenv coversdescribe,it,test,expect,expectTypeOf,vi,beforeEach/afterEach/beforeAll/afterAll, mirroring"types": ["vitest/globals"].fixturesglobal, installed intest/setup.tsviaObject.defineProperty(global, 'fixtures', ...), is declared as a readonly global in the same override.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: