zstandard: probe musllinux riscv64 (experiment, do not merge as is) - #203
Draft
gounthar wants to merge 1 commit into
Draft
zstandard: probe musllinux riscv64 (experiment, do not merge as is)#203gounthar wants to merge 1 commit into
gounthar wants to merge 1 commit into
Conversation
Tracks the musllinux gap noted in #163. build-zstandard.yml builds manylinux only, while upstream builds both. quay.io/pypa/musllinux_1_2_riscv64 exists and is tagged daily, so the image was never the blocker. One Python version, no publish job. Three things are pre-empted rather than found one run at a time: build-frontend drops to plain build because uv has no musl riscv64 binary, cffi will build from source because our registry carries riscv64 cffi as manylinux only, and before-all is widened to apk because zstandard guards it on /usr/bin/yum, which a musl image does not have. Signed-off-by: Bruno Verachten <gounthar@gmail.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft on purpose. This is the musllinux experiment from #163, kept to the budget you asked for: one Python version, no publish job, and it gets closed or folded into
build-zstandard.ymldepending on what the run says.quay.io/pypa/musllinux_1_2_riscv64exists and is tagged daily (latest today), so the image was never the blocker. Three things looked likely to bite, so they are handled up front rather than found one run at a time:pyproject.tomlsetsbuild-frontend = "build[uv]"globally. uv has no musl riscv64 binary to install in the container. Overridden to plainbuild, which is what upstream does on their musllinux builds with the comment "uv not present on musllinux cross-compiled images".test-groups = ["dev"]pulls cffi, and our registry carries riscv64 cffi as manylinux only (checked today, 23 files, no musllinux). So it builds from source in the container.before-allisif [ -x /usr/bin/yum ]; then yum install -y libffi-devel; fi, and a musl image has no yum, so today it installs nothing there.CIBW_BEFORE_ALL_LINUXis widened to cover apk while keeping the yum branch.What I do not know yet is whether the extension itself compiles clean against musl, and whether
ZSTD_WARNINGS_AS_ERRORS=1survives the different toolchain. That is what this run is for.If it goes green I will open a real PR folding the jobs into
build-zstandard.yml. If it does not, the failure is the answer and I will write it up on #163 so the next person does not start from zero.Refs #163