[textinput] Only force tty output when stdout is redirected - #23039
Open
guitargeek wants to merge 1 commit into
Open
[textinput] Only force tty output when stdout is redirected#23039guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
guitargeek
marked this pull request as draft
August 6, 2026 13:24
guitargeek
marked this pull request as ready for review
August 6, 2026 13:26
ec7998a made the display claim tty mode whenever /dev/tty could be opened, instead of only when stdout is not a terminal. The prompt was then printed even when IsInteractive() said otherwise, which broke roottest-root-rint-TabCom: its pty has no session leader, so the display is not interactive, but the "root [N]" prompts leaked into the output. /dev/tty is the controlling terminal of the process, which is unrelated to the pty the test writes to. The test therefore only failed when ctest was run from a terminal, and the CI stayed green. Restore the original condition, and query stdout for the terminal size whenever it is a terminal. 🤖 Done with the help of AI.
guitargeek
force-pushed
the
followup-22948
branch
from
August 6, 2026 13:27
7c5d3e6 to
e363723
Compare
Test Results 23 files 23 suites 3d 15h 2m 20s ⏱️ For more details on these failures, see this check. Results for commit e363723. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ec7998a made the display claim tty mode whenever /dev/tty could be opened, instead of only when stdout is not a terminal. The prompt was then printed even when IsInteractive() said otherwise, which broke roottest-root-rint-TabCom: its pty has no session leader, so the display is not interactive, but the "root [N]" prompts leaked into the output.
/dev/tty is the controlling terminal of the process, which is unrelated to the pty the test writes to. The test therefore only failed when ctest was run from a terminal, and the CI stayed green.
Restore the original condition, and query stdout for the terminal size whenever it is a terminal.
🤖 Done with the help of AI.
Follows up on: