[Python][ML] Fix and re-enable rdataloader xgboost tutorial - #23044
Merged
Conversation
siliataider
requested review from
bellenot,
couet,
dpiparo,
guitargeek and
vepadulano
as code owners
August 6, 2026 18:37
vepadulano
requested changes
Aug 7, 2026
vepadulano
left a comment
Member
There was a problem hiding this comment.
Nice work investigating this! The changes look good overall but I left some minor comments related to commit and code structure
siliataider
force-pushed
the
tmva-tutorial
branch
2 times, most recently
from
August 7, 2026 11:02
37a07c0 to
0da11f0
Compare
Previously, the `columns` keyword argument in RDataLoader's constructor required all `target` and `weight` columns to also be listed explicitly. This is no longer required, targets and weights can be specified independently without needing to be duplicated in `columns`. Additionally batches previously returned copies for features and targets but views for weights. This has changes and RDataLoader now returns views for all three.
siliataider
force-pushed
the
tmva-tutorial
branch
from
August 7, 2026 11:06
0da11f0 to
aba9e2f
Compare
Test Results 22 files 22 suites 3d 15h 28m 59s ⏱️ For more details on these failures, see this check. Results for commit aba9e2f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR fixes the ml_dataloader XGBoost tutorial, which had to be turned off because it crashed sporadically in CI, 2 separate issues are fixed here:
load_datafunction, so the weights view could end up pointing at memory that was already gone.columnspreviously required all training columns + targets + wieghts to be present in that list, it is no longer the case