Add tests for hsys-denote - #1034
Merged
Merged
Conversation
* test/MANIFEST: New test file.
* test/hsys-denote-tests.el (hsys-denote-tests--denote-link):
(hsys-denote-tests--link-to-denote):
(hsys-denote-tests--link-at-p):
(hsys-denote-tests--file-at-p): Test cases.
matsl
force-pushed
the
pr_add_denote_tests
branch
from
August 10, 2026 14:20
f0b0d10 to
c6f71c2
Compare
rswgnu
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test/MANIFEST: New test file.
test/hsys-denote-tests.el (hsys-denote-tests--denote-link):
(hsys-denote-tests--link-to-denote):
(hsys-denote-tests--link-at-p):
(hsys-denote-tests--file-at-p): Test cases.
Why
hsys-denote adds new ibut support for denote links and needs tests.
Note
These tests are based on not installing denote for the tests. The
denote functions are mocked for essentially unit testing our
integration code.
There are pros and cons with this practice. Maybe this is a good time
to kick off looking over our test strategy when it comes to testing
the integration with external packages. I'll share my ideas in a
separate email thread.