Use PDCursesMod instead of forked PDCurses - #154
Merged
Conversation
The vendored PDCurses was a fork of Bill Gray's PDCurses (now PDCursesMod) with a workaround to display full-width characters correctly on new Windows consoles. The workaround was merged upstream in PDCursesMod commit f69a0d02 and superseded by a more robust implementation in commit fac87bd9, so the fork is no longer needed. Point the submodule at Bill-Gray/PDCursesMod and update extconf.rb for the new makefile name (Makefile.mng was replaced by Makefile in the wincon port). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PDCursesMod's PDC_beep() calls PlaySound(), so linking the static pdcurses library fails with an undefined reference to __imp_PlaySoundW unless winmm is also linked. The mswin build is not affected because pdcurses.dll is linked against winmm.lib by Makefile.vc. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.