Remove rubyvm: keyword argument from Prism.find - #4202
Open
eregon wants to merge 1 commit into
Open
Conversation
Member
Author
|
(CI seems to not run because of a GitHub Actions outage) |
eregon
force-pushed
the
find-remove-rubyvm-keyword-argument
branch
from
August 7, 2026 15:32
80cf417 to
fe57f42
Compare
kddnewton
requested changes
Aug 14, 2026
| else | ||
| LineProcFind.new.find(callable) | ||
| end | ||
| when Method, UnboundMethod |
Collaborator
There was a problem hiding this comment.
I would prefer these to stay as separate classes, as the point is that you only have to switch on the callable in one place.
Member
Author
There was a problem hiding this comment.
Done. It also makes the diff a lot smaller.
* This does not scale well with more find implementations. * RubyVM is CRuby-specific and experimental so not something usually exposed in public APIs. * Tests can use the specific class directly, which is more reliable.
eregon
force-pushed
the
find-remove-rubyvm-keyword-argument
branch
from
August 14, 2026 19:31
fe57f42 to
0359415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
rubyvm:keyword argument fromPrism.find. The internal dispatch already checksdefined?(::RubyVM), so exposing this as a public parameter seems unnecessary. Removing it makes the API cleaner and makes it straightforward to test eachFindimplementation directly using the concrete classes.Additionally, unifiedLineMethodFind,LineLambdaFind, andLineProcFindinto a singleLineCallableFindclass, since they share the same structure (parse file, match by start line).