Correctly apply rdoc prerequisite - #4209
Merged
Merged
Conversation
Earlopain
had a problem deploying
to
github-pages
August 19, 2026 12:44 — with 
GitHub Actions
Failure
GitHub Actions
Failure
It thought this didn't actually work but it seems it is necessary this way. Unclear why `enhance` worked for the docs workflow but not for pages
Earlopain
force-pushed
the
fix-pages-docs
branch
from
August 19, 2026 12:45
a466c7f to
8f3e207
Compare
Earlopain
marked this pull request as ready for review
August 19, 2026 12:55
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the compile prerequisite is attached to the RDoc rake tasks so it reliably runs before RDoc’s own prerequisites/actions, and then removes an explicit “templates” step from the GitHub Pages workflow since templating/compilation is now handled via the RDoc task prerequisites.
Changes:
- Prepend
compileto the prerequisite list forrdoc,rerdoc, andrdoc:coveragetasks (instead of usingenhance). - Remove the explicit
bundle exec rake templatesstep from the GitHub Pages workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rakelib/rdoc.rake | Ensures compile runs before RDoc task execution by prepending it to prerequisites. |
| .github/workflows/github-pages.yml | Drops the standalone templates step now that RDoc tasks enforce compilation/templating ordering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
I wish I could block this waste of resources |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought this didn't actually work but it seems it is necessary this way. Unclear why
enhanceworked for the docs workflow but not for pages