Fix SyckParser leak in Syck.compile - #66
Merged
Merged
Conversation
rb_syck_compile freed the parser only at the end of the function, so the rb_raise for a missing root node leaked it, as would NoMemoryError from the result string allocation. Free the parser before raising, and take ownership of the bytecode buffer so the parser can be freed before building the Ruby string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rb_syck_compilefreed itsSyckParseronly at the end of the function, so therb_raisefor a missing root node leaked it, as did aNoMemoryErrorfrom the result string allocation introduced in #63. Free the parser before raising, and on the normal path take ownership of the bytecode buffer from the parser's symbol table (syck_st_free_symsskips a NULLedbuffer) so the parser is freed before any Ruby allocation that may raise.