allow references to point to invalid values - #2335
Closed
nia-e wants to merge 1 commit into
Closed
Conversation
RalfJung
reviewed
Aug 23, 2026
|
|
||
| r[undefined.validity.reference-box] | ||
| * A reference or [`Box<T>`] must be aligned and non-null, it cannot be [dangling], and it must point to a valid value (in case of dynamically sized types, using the actual dynamic type of the pointee as determined by the [metadata]). Note that the last point (about pointing to a valid value) remains a subject of some debate. | ||
| * A reference or [`Box<T>`] must be aligned and non-null, and cannot be [dangling]. |
Member
There was a problem hiding this comment.
This is missing the requirement that the pointee type must be inhabited (and there is a bit of subtlety around what exactly "inhabited" means).
Member
|
#2337 supersedes this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @rust-lang/opsem FCP in rust-lang/unsafe-code-guidelines#414 (comment), partially unblocking rust-lang/rust#161452. This would mean invalid references are downgraded to being library UB (but invalid values are still lang UB).