Skip to content

sanitizers: Implement support for the sanitize ignorelist - #157808

Open
1c3t3a wants to merge 1 commit into
rust-lang:mainfrom
1c3t3a:sanitizer-ignorelist
Open

sanitizers: Implement support for the sanitize ignorelist#157808
1c3t3a wants to merge 1 commit into
rust-lang:mainfrom
1c3t3a:sanitizer-ignorelist

Conversation

@1c3t3a

@1c3t3a 1c3t3a commented Jun 12, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

The sanitize ignorelist gives central controls over which functions, files, etc. should be ignored and not sanitized. It is a common file format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change adds support for this list in Rust as well.

r? @rcvalle

@rustbot

rustbot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 12, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch 2 times, most recently from 624834b to 693e22f Compare June 12, 2026 12:49
@1c3t3a
1c3t3a requested a review from rcvalle June 12, 2026 14:20
rcvalle
rcvalle reviewed Jun 12, 2026
View reviewed changes
Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated
rcvalle
rcvalle reviewed Jun 12, 2026
View reviewed changes
Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated
rcvalle
rcvalle reviewed Jun 12, 2026
View reviewed changes
Comment thread compiler/rustc_codegen_llvm/src/builder.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026
@1c3t3a
1c3t3a requested a review from rcvalle June 15, 2026 08:54
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rcvalle
rcvalle requested changes Jul 28, 2026
View reviewed changes
Comment thread compiler/rustc_codegen_llvm/src/common.rs Outdated
Comment thread tests/codegen-llvm/sanitizer/ignorelist/cfi-ignorelist.rs
Comment thread compiler/rustc_codegen_llvm/src/llvm/mod.rs Outdated
Comment thread compiler/rustc_codegen_llvm/src/attributes.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2026
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from a24ff27 to eeed708 Compare August 27, 2026 10:12
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from eeed708 to 066c9e1 Compare August 27, 2026 10:17
@1c3t3a
1c3t3a requested a review from rcvalle August 27, 2026 10:18
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 27, 2026
jakos-sec
jakos-sec reviewed Aug 27, 2026
View reviewed changes
Comment thread tests/codegen-llvm/sanitizer/ignorelist/ignorelist.txt Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from 3f6de90 to 1cb8361 Compare August 27, 2026 16:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from 1cb8361 to a9e36d5 Compare August 28, 2026 08:59
@rust-bors

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from a9e36d5 to f071cb7 Compare August 31, 2026 16:17
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from 4d27534 to 40db0f2 Compare August 31, 2026 17:43
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from 40db0f2 to 2f2945e Compare August 31, 2026 18:33
dingxiangfei2009
dingxiangfei2009 reviewed Aug 31, 2026
View reviewed changes
Comment thread compiler/rustc_codegen_llvm/src/consts.rs Outdated
dingxiangfei2009
dingxiangfei2009 reviewed Aug 31, 2026
View reviewed changes
Comment thread compiler/rustc_sanitizers/src/ignorelist/ffi.rs
dingxiangfei2009
dingxiangfei2009 reviewed Aug 31, 2026
View reviewed changes
Comment thread compiler/rustc_sanitizers/src/ignorelist/ffi.rs Outdated
dingxiangfei2009
dingxiangfei2009 reviewed Aug 31, 2026
View reviewed changes
Comment thread compiler/rustc_sanitizers/src/ignorelist/mod.rs
rcvalle
rcvalle reviewed Sep 1, 2026
View reviewed changes
Comment thread compiler/rustc_codegen_llvm/src/attributes.rs
Comment thread compiler/rustc_codegen_llvm/src/attributes.rs Outdated
Comment thread compiler/rustc_codegen_llvm/src/context.rs Outdated
@1c3t3a
sanitizers: Implement support for the sanitize ignorelist
ae85fdc 
The sanitize ignorelist gives central controls over which functions,
files, etc. should be ignored and not sanitized. It is a common file
format for clang and explained here:
https://clang.llvm.org/docs/SanitizerSpecialCaseList.html. This change
adds support for this list in Rust as well.
@1c3t3a

1c3t3a commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Squashed all commits, this is ready from my side @rcvalle.

@1c3t3a
1c3t3a force-pushed the sanitizer-ignorelist branch from 5d4adb1 to ae85fdc Compare September 2, 2026 11:41
@rcvalle

rcvalle commented Sep 2, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ae85fdc has been approved by rcvalle

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2026
@rcvalle

rcvalle commented Sep 2, 2026

Copy link
Copy Markdown
Member

Thank you very much for all your time and work on this, Bastian! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcvalle rcvalle rcvalle requested changes
@dingxiangfei2009 dingxiangfei2009 dingxiangfei2009 left review comments
@jakos-sec jakos-sec jakos-sec left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@rcvalle rcvalle

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@1c3t3a @rustbot @rust-log-analyzer @rcvalle @dingxiangfei2009 @jakos-sec