Skip to content

add Complex ABI run-make test - #161694

Open
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:complex-abi-run-make
Open

add Complex ABI run-make test#161694
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:complex-abi-run-make

Conversation

@folkertdev

@folkertdev folkertdev commented Aug 24, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

tracking issue: #154023

Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.

@folkertdev folkertdev added the F-complex_numbers `#![feature(complex_numbers)]` label Aug 24, 2026
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2026
@folkertdev

folkertdev commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 24, 2026
@bors
Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>
a897fb9 
add `Complex` ABI run-make test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

💔 Test for a897fb9 failed: CI. Failed jobs:

@folkertdev
folkertdev force-pushed the complex-abi-run-make branch 2 times, most recently from 9dfa414 to c8d5ba7 Compare August 25, 2026 18:29
@folkertdev

folkertdev commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
@bors
Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>
88fe395 
add `Complex` ABI run-make test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev force-pushed the complex-abi-run-make branch from c8d5ba7 to d8cf4ed Compare August 25, 2026 19:23
@folkertdev

folkertdev commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
@bors
Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>
6467fdd 
add `Complex` ABI run-make test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev force-pushed the complex-abi-run-make branch from d8cf4ed to 2186035 Compare August 25, 2026 22:13
@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 6467fdd failed: CI. Failed jobs:

@folkertdev

folkertdev commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
@bors
Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>
b1df54a 
add `Complex` ABI run-make test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b1df54a (b1df54ab6df9bedeef96a0f94e4dd2e3ed9d73b9)
Base parent: 787af2b (787af2b8c80638c51a4fc8e44f84e6891f243ec7)

@folkertdev
folkertdev marked this pull request as ready for review August 27, 2026 10:38
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2026
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2026
@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev

folkertdev commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

the sync from #162119 should have fixed that armhf issue.

@bors try jobs=armhf-gnu

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 2, 2026
@bors
Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>
7e1279f 
add `Complex` ABI run-make test


try-job: armhf-gnu
@rust-bors

rust-bors Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 7e1279f (7e1279f2f1b93c206fcab6febbfc0bfdd165d4c7)
Base parent: c25253f (c25253fac451fff60fb5b6c0b2c64d60f628c7cd)

@folkertdev

folkertdev commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=JohnTitor

@rust-bors

rust-bors Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c80b2bf has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 2, 2026
@Zalathar
Rollup merge of rust-lang#161694 - folkertdev:complex-abi-run-make, r…
a9dd1de 
…=JohnTitor

add `Complex` ABI run-make test

tracking issue: rust-lang#154023

Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.
@Zalathar Zalathar mentioned this pull request Sep 2, 2026
Closed
@Zalathar

Zalathar commented Sep 2, 2026

Copy link
Copy Markdown
Member

Failed in rollup in test-various: #162189 (comment)

@bors r-

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2026
@rust-bors

rust-bors Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#162189), which was unapproved.

View changes since this unapproval

@folkertdev

folkertdev commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-,i686-msvc-,arm-android,armhf-gnu

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 2, 2026
@bors
Auto merge of #161694 - folkertdev:complex-abi-run-make, r=<try>
9624189 
add `Complex` ABI run-make test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: i686-msvc-*
try-job: arm-android
try-job: armhf-gnu
@rust-bors

rust-bors Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 9624189 (9624189386498e7c4819290f358ad2d4016f4289)
Base parent: 824336a (824336ad4127ce295849937a24c08a4aeff6ada7)

@folkertdev

folkertdev commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors rollup=iffy

@bors r=JohnTitor

@rust-bors

rust-bors Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b13c235 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 3, 2026
@Zalathar
Rollup merge of rust-lang#161694 - folkertdev:complex-abi-run-make, r…
022563b 
…=JohnTitor

add `Complex` ABI run-make test

tracking issue: rust-lang#154023

Just some back and forth between C and Rust, as a first line of defense against ABI mismatches. Something like abi-cafe is better because it just tests more scenarios than we reasonably can here, but now we run something on CI at least.
@Zalathar Zalathar mentioned this pull request Sep 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels

A-run-make Area: port run-make Makefiles to rmake.rs F-complex_numbers `#![feature(complex_numbers)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@folkertdev @rust-log-analyzer @rustbot @Zalathar @JohnTitor