Skip to content

Rollup of 25 pull requests - #162229

Merged
rust-bors[bot] merged 71 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pXEadbd
Sep 3, 2026
Merged

Rollup of 25 pull requests#162229
rust-bors[bot] merged 71 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pXEadbd

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

chenyukang and others added 30 commits August 27, 2026 12:25
Previously, these tests were testing the wrong feature gate,
and had unnecessary type errors.
This is done so that we can test whether the location used is at
the function call site or the await site.
Co-authored-by: Ralf Jung <post@ralfj.de>
- Rename `generate_*` functions to `emit_*`, since they emit LLVM globals
- Consistently use qualified paths in `counter_for_term`
- Remove an unnecessary Clone from `llvm_cov::Regions`
One of the key tasks in coverage codegen is to take the source-code spans that
were recorded during MIR instrumentation, and resolve them to physical
coordinates in their respective files.

In rare cases this resolution can fail, which leads to the awkward possibility
that a function might lose _all_ of its mappings for a particular
file/expansion. If that happens, we need to avoid emitting a covfun file
section containing no regions, because doing so would trigger errors in LLVM.

The existing code does handle this edge case, but in a way that won't
generalise to multiple files/expansions. Having an explicit intermediate
resolution step will make it easier to add support for expansion regions in the
future.
`suggest_fn_call` only fired when the failing obligation came from
`ObligationCauseCode::FunctionArg`, so a fn item or closure used as the
iterator of a `for` loop got no structured suggestion to call it.

the iterator of a `for` loop is passed to `IntoIterator::into_iter`, so the
failing `Iterator` goal is a derived obligation and the cause span carries the
loop desugaring, which makes `can_be_used_for_suggestions` return false. carry
the `HirId` of the iterator expression in `ObligationCauseCode::ForLoopIterator`
and gate the suggestion on the span of that expression instead.

rust-lang#161564
dereferencing an uncalled function only said the function type cannot be
dereferenced. it now suggests the call, gated on the return type actually
being dereferenceable.

rust-lang#161564 (comment)
…low`

VxWorks' libc defines no `O_NOFOLLOW`, so building std for
x86_64-wrs-vxworks stopped compiling once `set_perm_nofollow` was
consolidated into `sys/fs/unix.rs` without a vxworks guard. VxWorks also
has no way to express a no-follow permission change: its `fchmodat`
rejects `AT_SYMLINK_NOFOLLOW` with `ENOTSUP`. Return `Unsupported`,
matching the existing Android stub.
Make it also enabled by default just like it is for clang.
Our `LLVMRustVersion*` functions get hard-coded `LLVM_VERSION_*` values
when we build `RustWrapper.cpp`, but this could be different than the
actual LLVM library at runtime. This should never happen with toolchains
from `rustup`, but with external LLVM in a distro build, for example,
`rustc` and `LLVM` can be upgraded independently.

Most of the time when we check the LLVM version, we're only looking at
the major version anyway, and we already assert that these are equal in
`configure_llvm`. However, for anything that does check the minor or
patch version too, the runtime version is probably more relevant.
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d8df826 (parent) -> c33d8f3 (this PR)

Test differences

Show 307 test diffs

Stage 1

  • [ui (polonius)] tests/ui/async-await/track-caller/async-block.rs#afn_cls: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/async-await/track-caller/async-block.rs#cls: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/async-await/track-caller/async-closure-gate.rs#afn_cls: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/async-await/track-caller/async-closure-gate.rs#cls: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/async-await/track-caller/panic-track-caller.rs#afn_cls: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/generic_const_parameter_types/inherent-type-const.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/const-generics/generic_const_parameter_types/inherent-type-const.rs#old: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/const-generics/mgca/none-as-usize-const-arg.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/imports/macro-export-nested-import-visibility-issue-141134.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/lint/unused-braces-for-iterator-temp-scope-issue-160741.rs#e2021: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/lint/unused-braces-for-iterator-temp-scope-issue-160741.rs#e2024: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/parser/box-can-begin-expr.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/parser/removed-syntax/removed-syntax-uniq-mut-expr.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/suggestions/suggest-calling-fn-in-for-loop-issue-161564.rs: [missing] -> pass (J0)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64_power9: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J1)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64_vsx: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J1)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64le: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J1)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc_vsx: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J1)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#all: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J1)
  • [codegen] tests/codegen-llvm/i128-x86-align.rs: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J1)
  • [codegen] tests/codegen-llvm/intrinsics/volatile.rs: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J1)
  • [ui] tests/ui/async-await/track-caller/async-closure-gate.rs#afn_cls: [missing] -> pass (J5)
  • [ui] tests/ui/const-generics/generic_const_parameter_types/inherent-type-const.rs: pass -> [missing] (J5)
  • [ui] tests/ui/const-generics/generic_const_parameter_types/inherent-type-const.rs#next: [missing] -> pass (J5)
  • [ui] tests/ui/imports/macro-export-nested-import-visibility-issue-141134.rs: [missing] -> pass (J5)
  • [ui] tests/ui/lint/unused-braces-for-iterator-temp-scope-issue-160741.rs#e2024: [missing] -> pass (J5)
  • [ui] tests/ui/parser/box-can-begin-expr.rs: [missing] -> pass (J5)
  • [ui] tests/ui/parser/removed-syntax/removed-syntax-box.rs: pass -> [missing] (J5)
  • [ui] tests/ui/parser/removed-syntax/removed-syntax-uniq-mut-expr.rs: pass -> [missing] (J5)
  • [ui] tests/ui/suggestions/suggest-calling-fn-in-deref-issue-161564.rs: [missing] -> pass (J5)
  • [ui] tests/ui/suggestions/suggest-calling-fn-in-for-loop-issue-161564.rs: [missing] -> pass (J5)
  • [run-make] tests/run-make/complex-abi: [missing] -> pass (J6)
  • [rustdoc-html] tests/rustdoc-html/demo-allocator-54478.rs: pass -> [missing] (J6)
  • [rustdoc-html] tests/rustdoc-html/doc-test-attr-18199.rs: pass -> [missing] (J6)
  • [rustdoc-html] tests/rustdoc-html/edition-flag.rs: pass -> [missing] (J6)
  • [rustdoc-html] tests/rustdoc-html/no-run-still-checks-lints.rs: pass -> [missing] (J6)
  • [rustdoc-html] tests/rustdoc-html/test_option_check/test.rs: pass -> [missing] (J6)
  • [ui] tests/rustdoc-ui/doctest/demo-allocator-54478.rs: [missing] -> pass (J6)
  • [ui] tests/rustdoc-ui/doctest/doc-cfg-target-feature.rs: [missing] -> pass (J6)
  • [ui] tests/rustdoc-ui/doctest/edition-doctest.rs: [missing] -> pass (J6)
  • [ui] tests/rustdoc-ui/doctest/edition-flag.rs: [missing] -> pass (J6)
  • [ui] tests/rustdoc-ui/doctest/force-target-feature.rs: [missing] -> pass (J6)
  • [ui] tests/rustdoc-ui/doctest/process-termination.rs: [missing] -> pass (J6)
  • [ui] tests/rustdoc-ui/doctest/sanitizer-option.rs: [missing] -> ignore (ignored on targets without sanitizers support) (J6)
  • [ui] tests/rustdoc-ui/doctest/test-option-check-2.rs: [missing] -> pass (J6)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#missing: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J11)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#strong: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J11)
  • [codegen] tests/codegen-llvm/i128-x86-align.rs: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J11)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/demo-allocator-54478.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/doc-test-attr-18199.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/edition-doctest.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/edition-flag.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/ice-type-error-19181.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/process-termination.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/test_option_check/bar.rs: pass -> [missing] (J2)
  • [rustdoc-html] tests/rustdoc-html/test_option_check/test.rs: pass -> [missing] (J2)
  • [ui] tests/rustdoc-ui/doctest/demo-allocator-54478.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/edition-doctest.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/edition-flag.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/ice-type-error-19181.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/no-run-still-checks-lints.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/process-termination.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/test-option-check-2.rs: [missing] -> pass (J2)
  • [run-make] tests/run-make/complex-abi: [missing] -> pass (J3)
  • [rustdoc-html] tests/rustdoc-html/sanitizer-option.rs: ignore (ignored on targets without address sanitizer) -> [missing] (J4)
  • [ui] tests/rustdoc-ui/doctest/sanitizer-option.rs: [missing] -> ignore (ignored on targets without address sanitizer) (J4)
  • [crashes] tests/crashes/150969.rs: pass -> [missing] (J7)
  • [ui] tests/ui/async-await/track-caller/async-closure-gate.rs#cls: [missing] -> pass (J8)
  • [ui] tests/ui/const-generics/generic_const_parameter_types/inherent-type-const.rs#next: [missing] -> pass (J8)
  • [ui] tests/ui/const-generics/mgca/none-as-usize-const-arg.rs: [missing] -> pass (J8)
  • [ui] tests/ui/const-generics/mgca/type_const-adt-expr-missing-field.rs: [missing] -> pass (J8)
  • [ui] tests/ui/imports/macro-export-nested-import-visibility-issue-141134.rs: [missing] -> pass (J8)
  • [ui] tests/ui/parser/box-can-begin-expr.rs: [missing] -> pass (J8)
  • [ui] tests/ui/parser/removed-syntax/removed-syntax-box.rs: pass -> [missing] (J8)
  • [ui] tests/ui/parser/removed-syntax/removed-syntax-uniq-mut-expr.rs: pass -> [missing] (J8)
  • [ui] tests/ui/suggestions/suggest-calling-fn-in-deref-issue-161564.rs: [missing] -> pass (J8)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#all: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J9)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#missing: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J9)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#none: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J9)
  • [codegen] tests/codegen-llvm/i128-x86-align.rs: pass -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J9)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J10)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64_power9: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J10)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64_vsx: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J10)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64le: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J10)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc64le_power9: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J10)
  • [assembly] tests/assembly-llvm/asm/powerpc-types.rs#powerpc_power9: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J10)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#all: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J10)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#missing: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J10)
  • [assembly] tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect-2.rs#strong: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J10)
  • [rustdoc-html] tests/rustdoc-html/doc-cfg/doc-cfg-target-feature.rs: ignore (only executed when the architecture is x86_64) -> [missing] (J12)
  • [rustdoc-html] tests/rustdoc-html/force-target-feature.rs: ignore (only executed when the architecture is x86_64) -> [missing] (J12)
  • [ui] tests/ui/async-await/track-caller/panic-track-caller.rs#afn_cls: [missing] -> ignore (gcc backend is marked as ignore) (J13)
  • [run-make] tests/run-make/complex-abi: [missing] -> ignore (ignored when the target environment is msvc (_Complex is not supported by msvc)) (J14)
  • [ui] tests/rustdoc-ui/doctest/doc-cfg-target-feature.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J15)
  • [ui] tests/rustdoc-ui/doctest/doc-cfg-target-feature.rs: [missing] -> pass (J16)
  • [ui] tests/ui/async-await/track-caller/panic-track-caller.rs#afn_cls: [missing] -> pass (J17)
  • [codegen] tests/codegen-llvm/i128-x86-align.rs: ignore (only executed when the architecture is x86_64) -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J18)
  • [rustdoc-html] tests/rustdoc-html/sanitizer-option.rs: pass -> [missing] (J19)
  • [ui] tests/rustdoc-ui/doctest/sanitizer-option.rs: [missing] -> ignore (ignored on targets without sanitizers support) (J20)
  • [rustdoc-html] tests/rustdoc-html/force-target-feature.rs: pass -> [missing] (J21)

(and 73 additional test diffs)

Additionally, 134 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c33d8f3b5a50b56466998e8c5ed8a077d2caed84 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-21-3: 1h 20m -> 1h 59m (+47.9%)
  2. x86_64-gnu-nopt: 1h 40m -> 2h 27m (+46.6%)
  3. x86_64-gnu-aux: 1h 53m -> 2h 36m (+38.0%)
  4. x86_64-gnu-llvm-22-3: 1h 24m -> 1h 52m (+34.1%)
  5. x86_64-gnu-debug: 2h 12m -> 1h 29m (-32.1%)
  6. x86_64-gnu-miri: 1h 30m -> 1h 1m (-32.1%)
  7. dist-powerpc64-linux-gnu: 1h 17m -> 1h 39m (+29.5%)
  8. dist-x86_64-musl: 1h 50m -> 2h 23m (+29.4%)
  9. optional-x86_64-gnu-autodiff: 57m 33s -> 41m 2s (-28.7%)
  10. x86_64-gnu-parallel-frontend: 1h 36m -> 2h 2m (+27.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c33d8f3): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)
0.4% [0.2%, 0.7%] 18
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results (primary -2.3%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.2% [5.2%, 5.2%] 1
Regressions ❌
(secondary)
3.2% [0.9%, 7.4%] 7
Improvements ✅
(primary)
-6.1% [-7.7%, -4.4%] 2
Improvements ✅
(secondary)
-4.7% [-4.7%, -4.7%] 1
All ❌✅ (primary) -2.3% [-7.7%, 5.2%] 3

Cycles

Results (primary 2.5%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.3% [-6.3%, -6.3%] 1
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Binary size

Results (primary -0.0%, secondary -4.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 0.8%] 31
Regressions ❌
(secondary)
0.1% [0.0%, 0.1%] 5
Improvements ✅
(primary)
-1.2% [-1.7%, -0.2%] 6
Improvements ✅
(secondary)
-6.1% [-12.1%, -0.9%] 13
All ❌✅ (primary) -0.0% [-1.7%, 0.8%] 37

Bootstrap: 477.112s -> 477.05s (-0.01%)
Artifact size: 401.86 MiB -> 401.31 MiB (-0.14%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 3, 2026
@rust-bors

rust-bors Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#161694 add Complex ABI run-make test 6357c99df0c03b1f14bd11ae503dcb21993ba5b0
(link)
#162014 Move more rustdoc-html tests using --test into the righ… 9bee7a63b38fc8fb5026cec0eea9ebeeeaadb071
(link)
#162164 Revert "Implement Debug for C-like enums with a concatenate… a056d7dcd99f9cadb16ff584403fbd0819ba2796
(link)
#160564 volatile: allow accesses to non-AM memory to trap 0181ab7e5b0829851764f99a87819eec40778fd0
(link)
#161579 suggest calling a fn item used as the iterator of a for l… 6e36ad05c5a64a12464ba865ba9c388c03f6900f
(link)
#162044 coverage: Resolve spans to file-coordinates in a separate s… a88204a322864f930e09e5214a4709c5155b8f25
(link)
#162120 Introduce PerOwnerLoweringState aab878523993efaa06865b45519f9289712e38dc
(link)
#162132 std: improve safety documentation in UNIX stack overflow co… 6d171484245083b141b187291905960cbb2ff234
(link)
#162151 Test itanium mangling of f16 and f128 f599bb4633258224a8933445005dd2e2b2fc080b
(link)
#162162 Don't special-case ! in stability checks anymore 89bb80fedbaad33a7b38ecf933537809b2c3b027
(link)
#162181 Remove wrong UnusedBraces lint for iterator loop in edition… 8dcf23a483b723bbe490743cf6b435b8fd66087e
(link)
#162187 Rename thir::ExprKind::Use to ValueExpr e6ec71a89dd7ceacdecb165aad5207b039c1a4a3
(link)
#158401 mgca: Don't ICE when evaluating ValTrees that contain error… 3b029aab8fb4a749e0a8c18aa378f2e0831346bf
(link)
#159873 fuchsia: Add safestack as a supported sanitizer for x86_64 … 0d437986792fc276e45664f215ae40c50ef8307d
(link)
#161135 Add f16 and f128 inline ASM support for PowerPC 6b98390cb1c429eb239d34d1ff3170b75c959930
(link)
#161847 Preserve visibility in nested macro import suggestions a98e57d1ee4c3e5a2995b7379deadcd0b08104cd
(link)
#161972 Improve tests for #[track_caller] in async 4f2b81d67b6f65d5c3b9248c52fa9469e89c36fc
(link)
#162008 Render the box pattern removal diagnostic more actionable… 8dc4d928907059ebb55f342e398b58180dc551da
(link)
#162065 std: don't reference libc::O_NOFOLLOW on VxWorks in `set_… c1f0df62dadee478a246b8391a2ee943496d039c
(link)
#162076 docs(num): clarify conditions under which error occurs in `… fcd65aef8e4e90e0e44847f930e979bc3de5db45
(link)
#162111 Update mailmap for Will Crichton and Petr Hosek ffe89428195e9cba37d6db757a7829363fae4192
(link)
#162152 Revert "retrieve supported GCC targets from the sysroot" 930ad1ac8c9cab2c7225ba765176d9060f7a2cf7
(link)
#162153 Prefer LLVMGetVersion for runtime info 8d31877e03331746fe80e9ab2f76c0c06e46a1b9
(link)
#162168 fix ICE in project_goals/inherent 434df5a5af21d2c05e05177f408fa55fff48bdf5
(link)
#162171 Explain LoongArch f16 NaN-boxing in inline asm 7eecd28c45725abe0237a89aa24531fecb684acb
(link)

parent commit: d8df82673d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

Time to bully rust-timer, and see if it works with large amounts of PRs now

@rust-timer triage 6357c99 9bee7a6 a056d7d 0181ab7 6e36ad0 a88204a aab8785 6d17148 f599bb4 89bb80f 8dcf23a e6ec71a 3b029aa 0d43798 6b98390 a98e57d 4f2b81d 8dc4d92 c1f0df6 fcd65ae ffe8942 930ad1a 8d31877 434df5a 7eecd28

@rust-timer

rust-timer commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator
Running triage with 4 benchmarks

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

  • cranelift-codegen-0.119.0
  • ucd
  • wg-grammar
  • wg-grammar-new-solver

#161694 6357c99 add Complex ABI run-make test

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162014 9bee7a6 Move more rustdoc-html tests using --test into the right folder

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.


#162164 a056d7d Revert "Implement Debug for C-like enums with a concatenated string"

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.2%, 0.7%] 18
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 4.3%, secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.3% [4.3%, 4.3%] 1
Regressions ❌
(secondary)
2.2% [0.8%, 3.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.3% [4.3%, 4.3%] 1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.4%, secondary -6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.4% [0.2%, 0.6%] 8
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.5% [-12.1%, -0.9%] 12
All ❌✅ (primary) 0.4% [0.2%, 0.6%] 8

#160564 0181ab7 volatile: allow accesses to non-AM memory to trap

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#161579 6e36ad0 suggest calling a fn item used as the iterator of a for loop

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.


#162044 a88204a coverage: Resolve spans to file-coordinates in a separate step

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.


#162120 aab8785 Introduce PerOwnerLoweringState

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162132 6d17148 std: improve safety documentation in UNIX stack overflow code

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162151 f599bb4 Test itanium mangling of f16 and f128

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162162 89bb80f Don't special-case ! in stability checks anymore

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162181 8dcf23a Remove wrong UnusedBraces lint for iterator loop in edition 2024

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162187 e6ec71a Rename thir::ExprKind::Use to ValueExpr

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#158401 3b029aa mgca: Don't ICE when evaluating ValTrees that contain error constants

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#159873 0d43798 fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#161135 6b98390 Add f16 and f128 inline ASM support for PowerPC

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.3% [4.3%, 4.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.3% [4.3%, 4.3%] 1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#161847 a98e57d Preserve visibility in nested macro import suggestions

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#161972 4f2b81d Improve tests for #[track_caller] in async

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.


#162008 8dc4d92 Render the box pattern removal diagnostic more actionable & remove box expression recovery

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 1
Improvements ✅
(secondary)
-0.0% [-0.1%, -0.0%] 11
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 1

#162065 c1f0df6 std: don't reference libc::O_NOFOLLOW on VxWorks in set_perm_nofollow

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162076 fcd65ae docs(num): clarify conditions under which error occurs in impl TryFrom<int> for int

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162111 ffe8942 Update mailmap for Will Crichton and Petr Hosek

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162152 930ad1a Revert "retrieve supported GCC targets from the sysroot"

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162153 8d31877 Prefer LLVMGetVersion for runtime info

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 1
Improvements ✅
(secondary)
-0.0% [-0.1%, -0.0%] 11
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 1

#162168 434df5a fix ICE in project_goals/inherent

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.


#162171 7eecd28 Explain LoongArch f16 NaN-boxing in inline asm

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

@lqd

lqd commented Sep 3, 2026

Copy link
Copy Markdown
Member

#155452 was a small perf improvement and this rollup contains its revert, so it could be involved. I for one hope it’s not caused by the mailmap PR 😅

@panstromek

Copy link
Copy Markdown
Contributor

Yea, the debug one is certainly one of those, it affects wg-grammar.

@JonathanBrouwer

JonathanBrouwer commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

FYI I'm triaging on all PRs because we likely want to go to automatically benchmarking all rollup members in the future. This is just a system stress-test, there will probably be more on future rollups :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like perf-regression Performance regression. PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.