Fix incorrect contract filename in fallback handler tutorial - #902
Dev M (devtechedge) wants to merge 1 commit into
Conversation
|
Dev M (@devtechedge) could you please sign your commit? Thank you |
44d5274 to
4549b69
Compare
|
Done — the commit is now signed off with |
|
Hey Dev M (@devtechedge) this is what we refer to when signing commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits Sorry for the confusion |
Replace NoDelegatecallGuard.sol with ERC1271FallbackHandler.sol so the setup step matches the contract created later in the tutorial. Fixes safe-global#826 Signed-off-by: devtechedge <devtechedge@users.noreply.github.com>
4549b69 to
a5b479d
Compare
|
Thanks for the clarification, and no worries at all. I have reworked the commit to be cryptographically signed with my SSH key, following the GitHub docs you linked. The latest commit ( Let me know if anything else is needed on this PR. Thanks for the review. |
|
Thanks for the approval, Daniel (@dasanra). Both red checks fail for a reason that has nothing to do with this diff.
The two checks that only need Nothing changed after your review of |
Summary
NoDelegatecallGuard.sol, which is left over from the guards tutorial.ERC1271FallbackHandler.solso it matches the contract and tests in the rest of the page.Fixes #826
Test plan
ERC1271FallbackHandler.solERC1271FallbackHandler