feat(lightning-out): add template generate lightning-out command - #1045
Closed
akashdhake wants to merge 7 commits into
Closed
feat(lightning-out): add template generate lightning-out command#1045akashdhake wants to merge 7 commits into
template generate lightning-out command#1045akashdhake wants to merge 7 commits into
Conversation
Reads a JSON definition file and scaffolds the LO 2.0 metadata via @salesforce/templates. Always warns that the generated IframeWhiteListUrlSettings REPLACES the org's Trusted Domains list on deploy. Generate-only.
… success output - Rewrite src/commands/template/generate/lightning-out/index.ts to match the shipped @salesforce/templates LightningOutOptions shape (appName/eca.name, no distributionState/oauthScopes/force). Drops the interactive iframe-confirm/cancel path, --force, --no-prompt, --eca-distribution-state, --eca-oauth-scopes, and the old flat --name flag; adds --app-name, --eca-name. Extracts a pure, exported mergeLightningOutInputs() for per-key flag/definition-file precedence with wholesale list-replace for hostDomains/components, and a getSourceApiVersion() helper (SfProject, best-effort) for a CLI-side sourceApiVersion<68 advisory. Surfaces the generator's result.warnings and prints success guidance via this.info. - Rewrite messages/lightningOut.md to the exact key set run() references (verified by grep): drops iframe/force/no-prompt/eca-distribution-state/ eca-oauth-scopes/flags.name/error.missing-inputs keys, adds app-name/eca-name/definition-file summaries, error.definition-file-not-object, warning.unknown-definition-key, warning.source-api-version, and the success.* guidance keys. - Add unit test test/commands/template/generate/lightning-out/index.test.ts covering mergeLightningOutInputs precedence, list-replace semantics, and unknown-key reporting, plus the beta/hidden command metadata. - Regenerate command-snapshot.json and schemas/*.json (oclif `snapshot generate` / `schema generate`) so test:deprecation-policy and test:json-schema stay green against the new flag set; the schema diff for commands other than lightning-out is solely the pre-existing CreateOutput.warnings field already shipped by the linked generator.
…s without warnings field
This was referenced Sep 7, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
sf template generate lightning-outcommand (beta, hidden) — a generate-only scaffolder for Lightning Out 2.0 setup. Writes the 7 LO2 metadata artifacts (via the companion@salesforce/templatesgenerator, PR forcedotcom/salesforcedx-templates#880); deploys nothing itself and never contacts an org.Command layer
--app-name,--eca-name,--runtime(LWR_CORE|CLWR),--host-domains(multiple),--components(multiple),--eca-contact-email,--eca-callback-url,--definition-file,--output-dir,--api-version.--definition-file+ flags into one options object with per-key precedence; list keys (host-domains, components) replace wholesale.sourceApiVersion < 68deploy-floor warning and flags unknown--definition-filekeys; prints post-generate deploy guidance.Testing
iframeWhiteListUrlSettingsis absent; validation failure exits non-zero cleanly.Work item: W-24035498